cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-12353) UWP - splashscreen is not hidden.
Date Wed, 18 Jan 2017 15:42:26 GMT

    [ https://issues.apache.org/jira/browse/CB-12353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15828292#comment-15828292
] 

ASF GitHub Bot commented on CB-12353:
-------------------------------------

GitHub user daserge opened a pull request:

    https://github.com/apache/cordova-plugin-inappbrowser/pull/208

    CB-12353 Corrected merges usage in plugin.xml

    <!--
    Please make sure the checklist boxes are all checked before submitting the PR. The checklist
    is intended as a quick reference, for complete details please see our Contributor Guidelines:
    
    http://cordova.apache.org/contribute/contribute_guidelines.html
    
    Thanks!
    -->
    
    ### Platforms affected
    Windows, Browser, FirefoxOS
    
    ### What does this PR do?
    Use `runs` instead of `merges` to prevent proxy overriding by another plugin (see details
in the [Jira issue](https://issues.apache.org/jira/browse/CB-12353))
    
    ### What testing has been done on this change?
    Checked that splashscreen and inappbrowser works together
    
    ### Checklist
    - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA
database
    - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [ ] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/daserge/cordova-plugin-inappbrowser CB-12353

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-inappbrowser/pull/208.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #208
    
----
commit ca0970d9e81f8276028f77f35d65e103adefac2d
Author: daserge <v-seshak@microsoft.com>
Date:   2017-01-18T14:20:44Z

    CB-12353 Corrected merges usage in plugin.xml

----


> UWP - splashscreen is not hidden.
> ---------------------------------
>
>                 Key: CB-12353
>                 URL: https://issues.apache.org/jira/browse/CB-12353
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Plugin SplashScreen
>    Affects Versions: 4.0.0, 4.0.1
>         Environment: cordova-windows 4.4.3 , cordova-plugin-splashscreen 4.0.0, Win10
UWP.
>            Reporter: Ali Mustafa
>              Labels: reproduced, triaged, windows
>
> plugin hide() doesn't hide splashscreen in windows phone 10.
> tried updating both cordova-windows to latest master and cordova-plugin-splashscreen
to 4.0.1 and still seeing this.
> following a little debugging I did, it seems like hide() in splashscreen.js function
isn't beeing called and therefore 'hidden' class isn't added to the extendedsplashscreen div.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message