cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-12163) plugin.xml 'resource-file' does not copy file to target for Windows
Date Wed, 25 Jan 2017 15:50:26 GMT

    [ https://issues.apache.org/jira/browse/CB-12163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15837945#comment-15837945
] 

ASF subversion and git services commented on CB-12163:
------------------------------------------------------

Commit 8f89a1f4d72d3422b8be7e29e714fb4fc5ae9e1c in cordova-windows's branch refs/heads/master
from [~ktop500]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-windows.git;h=8f89a1f ]

CB-12163 Add resource-file reference functionality through a flag


> plugin.xml 'resource-file' does not copy file to target for Windows
> -------------------------------------------------------------------
>
>                 Key: CB-12163
>                 URL: https://issues.apache.org/jira/browse/CB-12163
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Windows
>    Affects Versions: Master
>         Environment: Windows 8/Windows10
>            Reporter: Karen Tran
>            Assignee: Karen Tran
>              Labels: Windows
>
> From plugin.xml:
> {noformat}<resource-file src="windows/shared/myprops.properties" target="myprops.properties"/>{noformat}
> <resource-file> does not copy the file from src to target anymore. It used to,
but was changed. This creates a couple of issues since I expect it to be in the application,
but it technically isn't. This means that I cannot update the file that doesn't exist and
very much limits the functionality of <resource-file> (Also the documentation is wrong
for Windows since it doesn't copy any files). Visual Studio also only shows the file from
the src path. This doesn't make much sense since that file wouldn't be in the application.

> The expected behavior should be if the target is specified, <resource-file> should
copy the file to the target location. In turn, Visual Studio should show the target file instead
of the src file because the target is part of the application whereas the src file is not.

> This used to be expected behavior, but was changed as a result of CB-10326. The intention
of that issue is limited to use cases of only having the src attribute, ignoring the possibility
that we would want to update files in the target instead (which imo makes more sense). Resource
files are not all .dll files, so it's not very user friendly to limit the <resource-file>
tag to handling just those kinds of files. 
> Proposed changes in JsprojManager.js and PluginHandler.js: 
> If target attribute is specified, copy the file to the target and point the Include attribute
to the path of the target. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message