cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-12018) Update tests to use jasmine instead of jasmine-node
Date Wed, 11 Jan 2017 07:16:58 GMT

    [ https://issues.apache.org/jira/browse/CB-12018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15817482#comment-15817482
] 

ASF GitHub Bot commented on CB-12018:
-------------------------------------

Github user vladimir-kotikov commented on a diff in the pull request:

    https://github.com/apache/cordova-cli/pull/265#discussion_r95522000
  
    --- Diff: spec/cli.spec.js ---
    @@ -55,76 +55,76 @@ describe("cordova cli", function () {
         });
     
         describe("options", function () {
    -        describe("version", function () {
    -            var version = require("../package").version;
    +      describe("version", function () {
    --- End diff --
    
    nit: could you please use 4 spaces for indentation to be consistent with the rest of the
tests/code?


> Update tests to use jasmine instead of jasmine-node
> ---------------------------------------------------
>
>                 Key: CB-12018
>                 URL: https://issues.apache.org/jira/browse/CB-12018
>             Project: Apache Cordova
>          Issue Type: Improvement
>          Components: Android, CLI, CordovaCommon, CordovaJS, CordovaLib, iOS, Plugman
>            Reporter: Steve Gill
>            Assignee: Audrey So
>              Labels: cordova-7.0.0
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message