cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-12008) Discuss moving towards autosave by default for cordova@7
Date Tue, 24 Jan 2017 19:27:26 GMT

    [ https://issues.apache.org/jira/browse/CB-12008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15836487#comment-15836487
] 

ASF GitHub Bot commented on CB-12008:
-------------------------------------

GitHub user audreyso opened a pull request:

    https://github.com/apache/cordova-cli/pull/266

    CB-12008 : made autosave the default for platform and plugin add/rm and included jasmine
tests

    CB-12008 : made autosave the default for platform and plugin add/rm and included jasmine
tests
    
    <!--
    Please make sure the checklist boxes are all checked before submitting the PR. The checklist
    is intended as a quick reference, for complete details please see our Contributor Guidelines:
    
    http://cordova.apache.org/contribute/contribute_guidelines.html
    
    Thanks!
    -->
    
    ### Platforms affected
    
    
    ### What does this PR do?
    Makes save the default setting for platform and plugin add/remove. Use --nosave if you
do not want to add or remove.
    
    ### What testing has been done on this change?
    
    
    ### Checklist
    - [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA
database
    - [ ] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [ ] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/audreyso/cordova-cli fixautosave

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-cli/pull/266.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #266
    
----
commit 4a5a6d3e9797db05209f3487c364e576ebfd1c6d
Author: Audrey So <audreyso@apache.org>
Date:   2017-01-24T19:10:30Z

    CB-12008 : made autosave the default for platform and plugin add/remove and included jasmine
testing

----


> Discuss moving towards autosave by default for cordova@7
> --------------------------------------------------------
>
>                 Key: CB-12008
>                 URL: https://issues.apache.org/jira/browse/CB-12008
>             Project: Apache Cordova
>          Issue Type: Improvement
>          Components: CordovaLib
>            Reporter: Steve Gill
>            Assignee: Audrey So
>              Labels: cordova-7.0.0
>             Fix For: 7.0.0
>
>
> Need to create a discuss thread about this. Our analytics show --save usage is pretty
low (presumably due to people not knowing about it). 
> It might be time to consider saving by default and having a --no-save flag to not save.

> We can also have global config to turn auto-save off for cordova 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message