cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-11154) Why timezone is not IANA ?
Date Thu, 05 Jan 2017 09:13:58 GMT

    [ https://issues.apache.org/jira/browse/CB-11154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15800849#comment-15800849
] 

ASF GitHub Bot commented on CB-11154:
-------------------------------------

Github user kosssi commented on the issue:

    https://github.com/apache/cordova-plugin-globalization/pull/53
  
    Thanks @shazron 
    
    - [x] update https://github.com/MSOpenTech/cordova-plugin-globalization to https://github.com/apache/cordova-plugin-globalization
    - [x] I fix timezone test:
    
    ```
                    expect(a.timezone).toBeDefined();
                    expect(typeof a.timezone).toBe('string');
                    if (!isBrowser) {
                        // The browser platform partially supports 'timezone'. Only Chrome
returns 'timezone' property.
                        // Its format is "Part of the world/{City}". Other browsers return
empty string.
                        // https://github.com/MSOpenTech/cordova-plugin-globalization/blob/21f8a0ffa5aa2497ee970b6b5092b4c65fc4bf7e/README.md#browser-quirks-4
                        expect(a.pattern.length > 0).toBe(true);
                    }
                    expect(a.timezone.length > 0).toBe(true);
    ```
    
    to
    
    ```
                    expect(a.timezone).toBeDefined();
                    expect(typeof a.timezone).toBe('string');
                    if (!isBrowser) {
                        // The browser platform partially supports 'timezone'. Only Chrome
returns 'timezone' property.
                        // Its format is "Part of the world/{City}". Other browsers return
empty string.
                        // https://github.com/apache/cordova-plugin-globalization/blob/21f8a0ffa5aa2497ee970b6b5092b4c65fc4bf7e/README.md#browser-quirks-4
                        expect(a.timezone.length > 0).toBe(true);
    }
    ```
    
    - [x] Add test to timezone_iana


> Why timezone is not IANA ?
> --------------------------
>
>                 Key: CB-11154
>                 URL: https://issues.apache.org/jira/browse/CB-11154
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Plugin Globalization
>            Reporter: Simon Constans
>              Labels: triaged
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> Hello,
> I don't understand why you don't return correctly the IANA timezone name?
> I think it's a simple information.
> I change my plugin for this repository: https://github.com/StyrLabs/cordova-plugin-globalization
> You can see commit:
> - for Android: https://github.com/StyrLabs/cordova-plugin-globalization/commit/b251053cc7b0fa0b055544437c8a960afedab530
> - for iPhone: https://github.com/StyrLabs/cordova-plugin-globalization/commit/1a67a5a94e45ecc037b3226f96ed3d2fab114c57
> Can you integrate it?
> Simon



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message