cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-9148) Add support for file picker in InAppBrowser
Date Wed, 04 Jan 2017 05:08:58 GMT

    [ https://issues.apache.org/jira/browse/CB-9148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15797191#comment-15797191
] 

ASF GitHub Bot commented on CB-9148:
------------------------------------

Github user darron1217 commented on a diff in the pull request:

    https://github.com/apache/cordova-plugin-inappbrowser/pull/205#discussion_r94530284
  
    --- Diff: src/android/InAppBrowser.java ---
    @@ -722,7 +729,57 @@ public void onClick(View v) {
                     inAppWebView = new WebView(cordova.getActivity());
                     inAppWebView.setLayoutParams(new LinearLayout.LayoutParams(LayoutParams.MATCH_PARENT,
LayoutParams.MATCH_PARENT));
                     inAppWebView.setId(Integer.valueOf(6));
    -                inAppWebView.setWebChromeClient(new InAppChromeClient(thatWebView));
    +                // File Chooser Implemented ChromeClient
    +                inAppWebView.setWebChromeClient(new InAppChromeClient(thatWebView) {
    +                    // For Android 5.0+
    +                    public boolean onShowFileChooser (WebView webView, ValueCallback<Uri[]>
filePathCallback, WebChromeClient.FileChooserParams fileChooserParams)
    +                    {
    +                        Log.d(LOG_TAG, "File Chooser 5.0+");
    --- End diff --
    
    @infil00p It's okay because I'm really enjoying this process :)
    I am the person who loves stable and beautiful codes.
    Thanks for all the comments and interests about my suggestion!
    I'm newbie here, but I'll try hard to be a good contributor here :D


> Add support for file picker in InAppBrowser
> -------------------------------------------
>
>                 Key: CB-9148
>                 URL: https://issues.apache.org/jira/browse/CB-9148
>             Project: Apache Cordova
>          Issue Type: Improvement
>          Components: Plugin InAppBrowser
>    Affects Versions: 3.5.0, 3.6.0
>         Environment: problem in Android, the camera roll never opens  (iOS working OK)
>            Reporter: Tomas Rawski
>              Labels: Android, camera, file, input, roll, triaged
>
> reproduce : 
> open the inAppBrowser: http://www.plupload.com/examples
> click in Add files.
> This works ok when I call it from the _system or _self. But not for _blank.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message