Mailing-List: contact issues-help@cordova.apache.org; run by ezmlm
Precedence: bulk
Date: Wed, 21 Dec 2016 09:16:58 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: issues@cordova.apache.org
Message-ID: <JIRA.13029663.1482308585000.570343.1482311818395@Atlassian.JIRA>
In-Reply-To: <JIRA.13029663.1482308585000@Atlassian.JIRA>
References: <JIRA.13029663.1482308585000@Atlassian.JIRA> <JIRA.13029663.1482308585922@arcas>
Subject: [jira] [Commented] (CB-12285) cordova-plugin-screen-orientation
 can't lock orientation on Android (API 19)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
archived-at: Wed, 21 Dec 2016 09:17:00 -0000


    [ https://issues.apache.org/jira/browse/CB-12285?page=3Dcom.atlassian.j=
ira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D157665=
53#comment-15766553 ]=20

ASF GitHub Bot commented on CB-12285:
-------------------------------------

GitHub user alsorokin opened a pull request:

    https://github.com/apache/cordova-plugin-screen-orientation/pull/8

    CB-12285 Polyfill promises on platforms that doesn't support them nat=
=E2=80=A6

    =E2=80=A6ively
   =20
    <!--
    Please make sure the checklist boxes are all checked before submitting =
the PR. The checklist
    is intended as a quick reference, for complete details please see our C=
ontributor Guidelines:
   =20
    http://cordova.apache.org/contribute/contribute_guidelines.html
   =20
    Thanks!
    -->
   =20
    ### Platforms affected
    All platforms with webview that doesn't support promises natively. For =
example, Android API level 19.
   =20
    ### What does this PR do?
    Includes a polyfill library so the promises (and therefore, `.lockScree=
n` function) would work everywhere.
   =20
    ### What testing has been done on this change?
    Paramedic tests on Android API 19.
   =20
    ### Checklist
    - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.h=
tml) in the JIRA database
    - [x] Commit message follows the format: "CB-3232: (android) Fix bug wi=
th resolving file paths", where CB-xxxx is the JIRA ID & "android" is the p=
latform affected.
    - [ ] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/alsorokin/cordova-plugin-screen-orientati=
on CB-12285

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-screen-orientation/pull/8.patc=
h

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #8
   =20
----
commit 4ab51641c26af31a08ebe578b33ad02a2e07093d
Author: Alexander Sorokin <alexander.sorokin@akvelon.com>
Date:   2016-12-21T09:10:19Z

    CB-12285 Polyfill promises on platforms that doesn't support them nativ=
ely

----


> cordova-plugin-screen-orientation can't lock orientation on Android (API =
19)
> -------------------------------------------------------------------------=
---
>
>                 Key: CB-12285
>                 URL: https://issues.apache.org/jira/browse/CB-12285
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Plugin Screen Orientation
>    Affects Versions: Master
>            Reporter: Alexander Sorokin
>            Assignee: Alexander Sorokin
>              Labels: found-by-ci, triaged
>


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org