cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-12300) Allow run cordova-plugin-contacts with jasmine-node
Date Tue, 27 Dec 2016 08:57:58 GMT

    [ https://issues.apache.org/jira/browse/CB-12300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15779971#comment-15779971
] 

ASF GitHub Bot commented on CB-12300:
-------------------------------------

Github user alsorokin commented on the issue:

    https://github.com/apache/cordova-plugin-contacts/pull/145
  
    Oh, I see.
    Please add Jira issue number to the commit message as follows: `CB-12300: fix tests failure
when running it using jasmine-node`, then it will be good to merge.


> Allow run cordova-plugin-contacts with jasmine-node
> ---------------------------------------------------
>
>                 Key: CB-12300
>                 URL: https://issues.apache.org/jira/browse/CB-12300
>             Project: Apache Cordova
>          Issue Type: Improvement
>          Components: CordovaJS
>            Reporter: Meir Rotstein
>            Priority: Minor
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> In nodejs convention when calling async test done() function with parameter it consider
it as error object and the test fails.
> In the cordova-plugin-contacts project on the following tests the done function is eventually
called with a parameter:
> contacts.spec.25
> contacts.spec.28
> contacts.spec.29
> If you'll run these tests with jasmine-node you'll get the following error:
> Message: [object Object] Stacktrace: undefined
> jasmine-node: https://github.com/mhevery/jasmine-node



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message