cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Commented] (CB-12297) Support WKProcessPool for cookie sharing
Date Mon, 26 Dec 2016 05:04:58 GMT


ASF GitHub Bot commented on CB-12297:

GitHub user anandvnath opened a pull request:

    CB-12297 Support WKProcessPool for cookie sharing

    ### Platforms affected
    ### What does this PR do?
    Adds a shared WKProcessPool via static factory and use it in the  WKWebView created by
this plugin. Any WKWebView created by cordova apps can utilize this shared WKProcessPool for
enabling cookie sharing.
    ### What testing has been done on this change?
    Added a unit test to check if the shared instance is correctly created. Testing the cookie
sharing functionality is hard to do via unit test.
    ### Checklist
    - [/] [Reported an issue]( in the JIRA
    - [/] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [/] Added automated test coverage as appropriate for this change.

You can merge this pull request into a Git repository by running:

    $ git pull master

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #27
commit 012afe0359bcb66b0221124b82e9f290dc60317e
Author: <>
Date:   2016-12-23T08:43:22Z

    Added shared WKProcessPool support.

commit 8d96f76ed56771726342a455136c3d387f4d6f04
Author: <>
Date:   2016-12-23T09:18:52Z

    README changes and minor correction in where WKProcessPool is added.

commit 7dbfc32beb749f2d9d5ef6ab922c5dec27c8a2f5
Author: <>
Date:   2016-12-23T10:04:59Z

    Correct license headers.

commit b536d8815dc738096d3c58a95d8d1722946cc112
Author: <>
Date:   2016-12-26T04:41:21Z

    Test case modified.


> Support WKProcessPool for cookie sharing
> ----------------------------------------
>                 Key: CB-12297
>                 URL:
>             Project: Apache Cordova
>          Issue Type: Improvement
>          Components: Plugin WKWebViewEngine
>    Affects Versions: 1.0.0
>            Reporter: Anand V Nath
>            Assignee: Shazron Abdullah
>              Labels: easyfix
>             Fix For: 1.2.1, 1.2.1-dev
>   Original Estimate: 8h
>  Remaining Estimate: 8h
> WKWebView provided by the plugin does not use any WKProcessPool. Using WKProcessPool
will help in sharing cookies across WKWebView instances. If the cordova app has a usecase
where it creates its own WKWebView instance, for instance, a remote login screen, then it
is better that the new WKWebView instance uses the same WKProcessPool. 
> In order to make this happen, I propose creating a WKProcessPool factory in this plugin
and publish that, so that the cordova app can use it for their WKWebView instances.
> I have a working model in my git branch:

This message was sent by Atlassian JIRA

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message