cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-12286) Screen Orientation plugin's tests should actually test the plugin
Date Wed, 21 Dec 2016 14:24:58 GMT

    [ https://issues.apache.org/jira/browse/CB-12286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15767172#comment-15767172
] 

ASF GitHub Bot commented on CB-12286:
-------------------------------------

Github user filmaj commented on the issue:

    https://github.com/apache/cordova-plugin-screen-orientation/pull/9
  
    Probably a good idea :D


> Screen Orientation plugin's tests should actually test the plugin
> -----------------------------------------------------------------
>
>                 Key: CB-12286
>                 URL: https://issues.apache.org/jira/browse/CB-12286
>             Project: Apache Cordova
>          Issue Type: Test
>          Components: Plugin Screen Orientation
>    Affects Versions: Master
>            Reporter: Alexander Sorokin
>            Assignee: Alexander Sorokin
>              Labels: found-by-ci, triaged
>
> As of now, they test built-in {{window.orientation}} object while the plugin provides
{{window.screen.orientation}} object.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message