cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-12286) Screen Orientation plugin's tests should actually test the plugin
Date Wed, 21 Dec 2016 12:20:58 GMT

    [ https://issues.apache.org/jira/browse/CB-12286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15766920#comment-15766920
] 

ASF GitHub Bot commented on CB-12286:
-------------------------------------

Github user cordova-qa commented on the issue:

    https://github.com/apache/cordova-plugin-screen-orientation/pull/9
  
    Cordova CI Build has completed successfully.
    
    **Commit**     - [Link](https://github.com/apache/cordova-plugin-screen-orientation/pull/9/commits/cd2ee4666d66190424df4efc9291c31be6d4781b)
    **Dashboard** - [Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/6/)
    
    | Builder Name  | Console Output | Test Report | Device Logs  |
    |     :---:     |     :---:      |   :---:     |     :---:    |
    | [Windows 8.1 Store]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/6//PLATFORM=windows-8.1-store/)
| [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/6//PLATFORM=windows-8.1-store/console)
| [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/6//PLATFORM=windows-8.1-store/testReport/)
| [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/6//PLATFORM=windows-8.1-store/artifact/)
|
    | [Windows 10  Store]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/6//PLATFORM=windows-10-store/)
| [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/6//PLATFORM=windows-10-store/console)
| [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/6//PLATFORM=windows-10-store/testReport/)
| [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/6//PLATFORM=windows-10-store/artifact/)
|
    | [Windows 8.1 Phone]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/6//PLATFORM=windows-8.1-phone/)
| [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/6//PLATFORM=windows-8.1-phone/console)
| [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/6//PLATFORM=windows-8.1-phone/testReport/)
| [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/6//PLATFORM=windows-8.1-phone/artifact/)
|
    | [iOS]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/6//PLATFORM=ios/)
| [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/6//PLATFORM=ios/console)
| [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/6//PLATFORM=ios/testReport/)
| [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/6//PLATFORM=ios/artifact/)
|
    | [Android]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/6//PLATFORM=android/)
| [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/6//PLATFORM=android/console)
| [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/6//PLATFORM=android/testReport/)
| [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/6//PLATFORM=android/artifact/)
|
     



> Screen Orientation plugin's tests should actually test the plugin
> -----------------------------------------------------------------
>
>                 Key: CB-12286
>                 URL: https://issues.apache.org/jira/browse/CB-12286
>             Project: Apache Cordova
>          Issue Type: Test
>          Components: Plugin Screen Orientation
>    Affects Versions: Master
>            Reporter: Alexander Sorokin
>            Assignee: Alexander Sorokin
>              Labels: found-by-ci, triaged
>
> As of now, they test built-in {{window.orientation}} object while the plugin provides
{{window.screen.orientation}} object.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message