cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-12264) media. getCurrentAmplitude has no the correct definition on the readme
Date Wed, 28 Dec 2016 21:34:58 GMT

    [ https://issues.apache.org/jira/browse/CB-12264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15783745#comment-15783745
] 

ASF GitHub Bot commented on CB-12264:
-------------------------------------

Github user jcesarmobile commented on a diff in the pull request:

    https://github.com/apache/cordova-plugin-media/pull/123#discussion_r94079923
  
    --- Diff: README.md ---
    @@ -104,7 +104,7 @@ The following constants are reported as the only parameter to the
     
     ### Methods
     
    -- `media.getCurrentAmplitude`: Returns the current position within an audio file.
    +- `media.getCurrentAmplitude`: Returns the current amplitude of the current recording.
    --- End diff --
    
    Because that definition is also wrong, you are not recording, so the "of the current recording"
makes no sense. And all the other function definitions say "within an audio file" or "of an
audio file"


> media. getCurrentAmplitude has no the correct definition on the readme
> ----------------------------------------------------------------------
>
>                 Key: CB-12264
>                 URL: https://issues.apache.org/jira/browse/CB-12264
>             Project: Apache Cordova
>          Issue Type: Bug
>            Reporter: Quique Fdez Guerra
>            Priority: Minor
>
> On the documentation of media plugin the getCurrentamplitude doesn't have the correct
definition, I've created a PR https://github.com/apache/cordova-plugin-media/pull/123/commits/f9b5703dcf7c9d66882b1bcf905158bc6de0571d



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message