cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joe Bowser (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-12218) inconsistent null handling between EVAL and ONLINE bridge modes
Date Mon, 05 Dec 2016 23:44:58 GMT

    [ https://issues.apache.org/jira/browse/CB-12218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15723759#comment-15723759
] 

Joe Bowser commented on CB-12218:
---------------------------------

[~akinzie] I agree, and we should be converting null to the string "null". since we're actually
executing Javascript and not mucking about with the ONLINE_EVENT bridge passing strings.

Which plugin does this fail the most on? That'd be helpful when writing tests for this thing.

> inconsistent null handling between EVAL and ONLINE bridge modes
> ---------------------------------------------------------------
>
>                 Key: CB-12218
>                 URL: https://issues.apache.org/jira/browse/CB-12218
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Android
>    Affects Versions: 6.0.0
>         Environment: Android
>            Reporter: Alan Kinzie
>
> If the Android native code invokes the success callback like this:
> callbackContext.success(null);
> then the value given to the javascript callback changes depending on the bridge type
used.
> If the ONLINE_EVENT type is used, then null will be passed to the javascript callback.
> ie: if result is the parameter of the javascript success callback then
> result === null  // will be true
> result === "" // will be false
> If the EVAL_BRIDGE type is used, then an empty string will be passed to the javascript
callback.
> ie: if result is the parameter of the javascript success callback then
> result === null  // will be false
> result === "" // will be true
> The value of the parameter given to the success callback should not change depending
on the bridge type.  Since ONLINE_EVENT was the default before cordova android 6.0.0, I am
inclined to think the ONLINE bridge is doing the correct behaviour.  Also, converting null
to an empty string loses information.  Therefore I think the EVAL mode should to be changed
to be consistent with the ONLINE mode.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message