cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-12163) plugin.xml 'resource-file' does not copy file to target for Windows
Date Tue, 13 Dec 2016 17:55:58 GMT

    [ https://issues.apache.org/jira/browse/CB-12163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15745769#comment-15745769
] 

ASF GitHub Bot commented on CB-12163:
-------------------------------------

GitHub user ktop opened a pull request:

    https://github.com/apache/cordova-lib/pull/509

    CB-12163 Add reference attrib to resource-file for Windows

    <!--
    Please make sure the checklist boxes are all checked before submitting the PR. The checklist
    is intended as a quick reference, for complete details please see our Contributor Guidelines:
    
    http://cordova.apache.org/contribute/contribute_guidelines.html
    
    Thanks!
    -->
    
    ### Platforms affected
    cordova-common for Windows
    
    ### What does this PR do?
    Adds a new attribute to the resource-file tag for Windows. The attribute is for moving
the current functionality of "referencing files" to be switched on by this flag in order to
bring back the copy functionality to be default for resource-file. 
    
    ex. 
    ```
    <resource-file src="x86/foo.dll" target="foo.dll" arch="x86" reference="true" />
    <resource-file src="x64/foo.dll" target="foo.dll" arch="x64" reference="true" />
    ```
    
    ### What testing has been done on this change?
    Manual testing and unit testing. Need to pull in changes from the cordova-windows pull
request to get it to work properly. 
    
    ### Checklist
    - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA
database
    - [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [X] Added automated test coverage as appropriate for this change.
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ktop/cordova-lib cb12163

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-lib/pull/509.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #509
    
----
commit 9d69d3df1d765ad9c05ece48864fc47c6c3e7061
Author: ktop <ktop500@gmail.com>
Date:   2016-12-12T19:35:04Z

    CB-12163 Add reference attrib to resource-file for Windows

----


> plugin.xml 'resource-file' does not copy file to target for Windows
> -------------------------------------------------------------------
>
>                 Key: CB-12163
>                 URL: https://issues.apache.org/jira/browse/CB-12163
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Windows
>    Affects Versions: Master
>         Environment: Windows 8/Windows10
>            Reporter: Karen Tran
>            Assignee: Karen Tran
>              Labels: Windows
>
> From plugin.xml:
> {noformat}<resource-file src="windows/shared/myprops.properties" target="myprops.properties"/>{noformat}
> <resource-file> does not copy the file from src to target anymore. It used to,
but was changed. This creates a couple of issues since I expect it to be in the application,
but it technically isn't. This means that I cannot update the file that doesn't exist and
very much limits the functionality of <resource-file> (Also the documentation is wrong
for Windows since it doesn't copy any files). Visual Studio also only shows the file from
the src path. This doesn't make much sense since that file wouldn't be in the application.

> The expected behavior should be if the target is specified, <resource-file> should
copy the file to the target location. In turn, Visual Studio should show the target file instead
of the src file because the target is part of the application whereas the src file is not.

> This used to be expected behavior, but was changed as a result of CB-10326. The intention
of that issue is limited to use cases of only having the src attribute, ignoring the possibility
that we would want to update files in the target instead (which imo makes more sense). Resource
files are not all .dll files, so it's not very user friendly to limit the <resource-file>
tag to handling just those kinds of files. 
> Proposed changes in JsprojManager.js and PluginHandler.js: 
> If target attribute is specified, copy the file to the target and point the Include attribute
to the path of the target. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message