cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Commented] (CB-12132) Add hidenotcloseoption
Date Thu, 01 Dec 2016 23:35:59 GMT


ASF GitHub Bot commented on CB-12132:

Github user jcesarmobile commented on a diff in the pull request:
    --- Diff: src/ios/CDVInAppBrowser.m ---
    @@ -246,25 +246,11 @@ - (void)show:(CDVInvokedUrlCommand*)command
     - (void)hide:(CDVInvokedUrlCommand*)command
    --- End diff --
    Just make it 
    ```- (void)hide:(CDVInvokedUrlCommand*)command
        [self browserHide];
    There is no need to create a new hide method, you can call browserHide directly

> Add hidenotcloseoption
> ----------------------
>                 Key: CB-12132
>                 URL:
>             Project: Apache Cordova
>          Issue Type: New Feature
>          Components: Plugin InAppBrowser
>            Reporter: Gaven Henry
>            Priority: Minor
>              Labels: features
>   Original Estimate: 24h
>  Remaining Estimate: 24h
> add a new option for android and ios:
> option: hidenotclose=yes
> this makes the done button on iOS or the X button android hide the inappbrowser webview
instead of closing and destroying it.
> this is useful when doing something like:
> load a webview hidden (so it's nice and preloaded for the user)
> use the show() method when the user clicks to see it
> use the done/X button to hide the window
> call the close() method when done to clean up
> this allows us to start pre-loading the data, open and close the window multiple times
without having to reload and then to call close when done to dispose of the view and clean

This message was sent by Atlassian JIRA

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message