cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Commented] (CB-11714) Camera plugin for windows does not properly set content-type when selecting JPG->PNG
Date Thu, 01 Dec 2016 19:16:00 GMT


ASF GitHub Bot commented on CB-11714:

GitHub user DisruptiveMind opened a pull request:

    CB-11714: (windows) added check for encoding in savePhoto() without height/width

    Please make sure the checklist boxes are all checked before submitting the PR. The checklist
    is intended as a quick reference, for complete details please see our Contributor Guidelines:
    ### Platforms affected
    Windows 10
    ### What does this PR do?
    Adds extra content-type check when capturing photos without specifying targetWidth and/or
targetHeight in options to preserve JPEG file extension.
    ### What testing has been done on this change?
    ### Checklist
    - [x] [Reported an issue]( in the JIRA
    - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [ ] Added automated test coverage as appropriate for this change.

You can merge this pull request into a Git repository by running:

    $ git pull master

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #242


> Camera plugin for windows does not properly set content-type when selecting JPG->PNG
> ------------------------------------------------------------------------------------
>                 Key: CB-11714
>                 URL:
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Plugin Camera
>    Affects Versions: Master
>         Environment: Windows 10
>            Reporter: Tyler Pham
>              Labels: easyfix, triaged, windows
> When selecting a JPG with encodingType = Camera.EncodingType.PNG, the resizeImage() will
not modify the target content type when converting canvas.toDataURL(...) -- the content-type
will still be image/jpeg but with a .png extension which will cause the browser to not render
to image and issue an error.
> Possibly related to: CB-8618
> I have created a small fix at:

This message was sent by Atlassian JIRA

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message