[ https://issues.apache.org/jira/browse/CB-11177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15751299#comment-15751299
]
ASF GitHub Bot commented on CB-11177:
-------------------------------------
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/216#discussion_r92601539
--- Diff: cordova-js-src/splashscreen.js ---
@@ -30,7 +30,8 @@ var schema = (isHosted || isWin10UWP && isMsAppxWeb) ? 'ms-appx-web'
: 'ms-appx'
var fileName = isPhone ? 'splashscreenphone.png' : 'splashscreen.png';
var splashImageSrc = schema + ':///images/' + fileName;
-var splashElement = null, extendedSplashImage = null, extendedSplashProgress = null;
+var splashElement = null, extendedSplashImage = null, extendedSplashProgress = null,
--- End diff --
nit: please put each definition on its own line - IMO it's be much easier to read
> SplashScreen gets shifted on Windows devices with soft navbar
> -------------------------------------------------------------
>
> Key: CB-11177
> URL: https://issues.apache.org/jira/browse/CB-11177
> Project: Apache Cordova
> Issue Type: Bug
> Components: Windows
> Reporter: Sergey Shakhnazarov
> Assignee: Sergey Shakhnazarov
> Labels: mustfix, splashscreen, triaged
> Attachments: extendedSplash[1].png, launchImage[1].png
>
>
> This can be partially avoided by showing a statusbar:
> {noformat}
> var statusBar = Windows.UI.ViewManagement.StatusBar.getForCurrentView();
> if (statusBar) {
> statusBar.backgroundColor = { a: 0, r: 41, g: 40, b: 38 };
> statusBar.backgroundOpacity = 1;
> statusBar.showAsync();
> }
> {noformat}
> This should be conditional to soft navigation bar presence though.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
|