cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-11177) SplashScreen gets shifted on Windows devices with soft navbar
Date Mon, 12 Dec 2016 18:36:59 GMT

    [ https://issues.apache.org/jira/browse/CB-11177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15742731#comment-15742731
] 

ASF GitHub Bot commented on CB-11177:
-------------------------------------

GitHub user daserge opened a pull request:

    https://github.com/apache/cordova-windows/pull/216

    CB-11177 SplashScreen gets shifted on Windows devices with soft navbar

    <!--
    Please make sure the checklist boxes are all checked before submitting the PR. The checklist
    is intended as a quick reference, for complete details please see our Contributor Guidelines:
    
    http://cordova.apache.org/contribute/contribute_guidelines.html
    
    Thanks!
    -->
    
    ### Platforms affected
    Windows
    
    ### What does this PR do?
    Fixes splash jump bug (affected mostly Windows 10 Mobile devices, especially with soft
navigation bar)
    
    ### What testing has been done on this change?
    Manual testing
    
    ### Checklist
    - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA
database
    - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [ ] Added automated test coverage as appropriate for this change.
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/daserge/cordova-windows CB-11177

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-windows/pull/216.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #216
    
----
commit 94b0c271fef8217c413c35ee401594f5f986b351
Author: daserge <v-seshak@microsoft.com>
Date:   2016-12-12T18:32:37Z

    CB-11177 SplashScreen gets shifted on Windows devices with soft navbar

----


> SplashScreen gets shifted on Windows devices with soft navbar
> -------------------------------------------------------------
>
>                 Key: CB-11177
>                 URL: https://issues.apache.org/jira/browse/CB-11177
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Windows
>            Reporter: Sergey Shakhnazarov
>            Assignee: Sergey Shakhnazarov
>              Labels: mustfix, splashscreen, triaged
>         Attachments: extendedSplash[1].png, launchImage[1].png
>
>
> This can be partially avoided by showing a statusbar:
> {noformat}
> var statusBar = Windows.UI.ViewManagement.StatusBar.getForCurrentView();
> if (statusBar) {
>     statusBar.backgroundColor = { a: 0, r: 41, g: 40, b: 38 };
>     statusBar.backgroundOpacity = 1;
>     statusBar.showAsync();
> }
> {noformat}
> This should be conditional to soft navigation bar presence though.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message