cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-10958) scripts/after_install.js overwrites content @src attribute
Date Fri, 09 Dec 2016 00:52:58 GMT

    [ https://issues.apache.org/jira/browse/CB-10958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15733879#comment-15733879
] 

ASF GitHub Bot commented on CB-10958:
-------------------------------------

Github user asfgit closed the pull request at:

    https://github.com/apache/cordova-plugins/pull/24


> scripts/after_install.js overwrites content @src attribute
> ----------------------------------------------------------
>
>                 Key: CB-10958
>                 URL: https://issues.apache.org/jira/browse/CB-10958
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Labs
>            Reporter: Andreas Kohn
>              Labels: triaged
>
> The scripts/after_install.js script of the cordova-labs-local-webserver overwrites the
'src' attribute of the 'content' element when it is executed, always setting the port to '0'
(randomised).
> This might be fine if one is working with the environment on a single checkout on a single
machine, where one merely has to modify the file afterwards; it might also be fine when one
opts to commit the platforms/ and plugins/ directories to source control.
> This doesn't seem a proper behaviour or assumption though: For example, in our environment
we use the https://github.com/SamVerschueren/gulp-cordova plugins to produce a reproducible
state as part of the integration build. A workaround would be to post-process the config.xml
and restore the port we need, but it is fairly easy to fix in the cordoba-labs-local-webserver
plugin.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message