cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-10033) new resizable cropping rectangle instead of Apple's standard square
Date Thu, 22 Dec 2016 12:41:58 GMT

    [ https://issues.apache.org/jira/browse/CB-10033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15769965#comment-15769965
] 

ASF GitHub Bot commented on CB-10033:
-------------------------------------

Github user cordova-qa commented on the issue:

    https://github.com/apache/cordova-plugin-camera/pull/131
  
    Cordova CI Build has one or more failures. 
    
    **Commit**     - [Link](https://github.com/apache/cordova-plugin-camera/pull/131/commits/51997470029563da9fc3b8d629bfbe6fcdf02936)
    **Dashboard** - [Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/112/)
    
    | Builder Name  | Console Output | Test Report | Device Logs  |
    |     :---:     |     :---:      |   :---:     |     :---:    |
    | [Windows 8.1 Store]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/112//PLATFORM=windows-8.1-store/)
| [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/112//PLATFORM=windows-8.1-store/console)
| [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/112//PLATFORM=windows-8.1-store/testReport/)
| [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/112//PLATFORM=windows-8.1-store/artifact/)
|
    | [Windows 10  Store]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/112//PLATFORM=windows-10-store/)
| [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/112//PLATFORM=windows-10-store/console)
| [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/112//PLATFORM=windows-10-store/testReport/)
| [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/112//PLATFORM=windows-10-store/artifact/)
|
    | [Windows 8.1 Phone]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/112//PLATFORM=windows-8.1-phone/)
| [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/112//PLATFORM=windows-8.1-phone/console)
| [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/112//PLATFORM=windows-8.1-phone/testReport/)
| [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/112//PLATFORM=windows-8.1-phone/artifact/)
|
    | [iOS]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/112//PLATFORM=ios/)
| [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/112//PLATFORM=ios/console)
| [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/112//PLATFORM=ios/testReport/)
| [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/112//PLATFORM=ios/artifact/)
|
    | [Android]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/112//PLATFORM=android/)
| [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/112//PLATFORM=android/console)
| [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/112//PLATFORM=android/testReport/)
| [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/112//PLATFORM=android/artifact/)
|
     



> new resizable cropping rectangle instead of Apple's standard square
> -------------------------------------------------------------------
>
>                 Key: CB-10033
>                 URL: https://issues.apache.org/jira/browse/CB-10033
>             Project: Apache Cordova
>          Issue Type: New Feature
>          Components: Plugin Camera
>         Environment: iOS
>            Reporter: Manfred Wühr
>            Priority: Minor
>              Labels: feature, iOS
>
> On iOS there's only that very insufficient inflexible cropping square – compared to
Android or WinMobile – which moreover obviously doesn’t work properly (see CB-9930, CB-2648).
> As we need a flexible, sizable rectangle, we implemented that in our fork of the camera
plugin.
> And with that we even already submitted a [pull request|https://github.com/apache/cordova-plugin-camera/pull/131].
> (being very new to Cordova we didn’t realize, that there obviously has to be such a
JIRA issue, before).
> To be downward compatible and to not urge others, for whom that square may be sufficient,
it is made parametrizable via a new preference (as this is iOS specific and nothing that has
to be changeable at runtime), defaulting to false.
> If the plugin is called with option allowEdit == true, then setting this new preference
to true suppresses that standard (fairly useless) square for cropping the photo, even suppresses
the (then also useless) view of the photo with the "Retake"- and "Use Photo"-buttons, but
instead offers a resizable cropping rectangle (with "Redo" and "Save“).
> More detail about how it’s implemented can be found in the comment of the mentioned
pull request;
> and as there already started a discussion, I added more detail and thoughts [here|https://github.com/apache/cordova-plugin-camera/pull/131#issuecomment-156117731]
and [here|https://github.com/apache/cordova-plugin-camera/pull/131#issuecomment-156988289].
> We think others could use and want that, too – in the standard plug in.
> Yes, it is platform specific, but on Android and WinMobile it’s already possible to
crop with a flexible rectangle (somehow – knowing, that Android also isn’t really satisfying).
> I also emailed dev@cordova.apache.org with a [proposal|http://callback.markmail.org/thread/5bjkv4ukymo6ybot].



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message