Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 99544200BD0 for ; Wed, 16 Nov 2016 06:25:01 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 97E6A160B15; Wed, 16 Nov 2016 05:25:01 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id EC916160B03 for ; Wed, 16 Nov 2016 06:25:00 +0100 (CET) Received: (qmail 92794 invoked by uid 500); 16 Nov 2016 05:24:59 -0000 Mailing-List: contact issues-help@cordova.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@cordova.apache.org Received: (qmail 92755 invoked by uid 99); 16 Nov 2016 05:24:58 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 16 Nov 2016 05:24:58 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 7A8A82C4C79 for ; Wed, 16 Nov 2016 05:24:58 +0000 (UTC) Date: Wed, 16 Nov 2016 05:24:58 +0000 (UTC) From: "ASF subversion and git services (JIRA)" To: issues@cordova.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CB-12130) Launch storyboard images are not updated or cleaned MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Wed, 16 Nov 2016 05:25:01 -0000 [ https://issues.apache.org/jira/browse/CB-12130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15669477#comment-15669477 ] ASF subversion and git services commented on CB-12130: ------------------------------------------------------ Commit 99219c1c4cd8d1000fb89a15449f2d25a57bef41 in cordova-ios's branch refs/heads/master from [~NielsLeenheer] [ https://git-wip-us.apache.org/repos/asf?p=cordova-ios.git;h=99219c1 ] CB-12130 - Launch storyboard images are not updated or cleaned The platform project directory needs to be relative to the project Launch screen images were not updated or cleaned in `updateLaunchStoryboardImages()` or `cleanLaunchStoryboardImages()` because the check for `Images.xcassets` in `getLaunchStoryboardImagesDir()` failed. The reason was that the `platformProjDir` and `projectRoot` were joined, while both were relative to the root directory. So the resulting directory was non-sensical. This changes makes `platformProjDir` relative to `cordovaProject.root`, which matches the same check in `updateSplashScreens()` and `updateIcons()`. This closes #276 > Launch storyboard images are not updated or cleaned > --------------------------------------------------- > > Key: CB-12130 > URL: https://issues.apache.org/jira/browse/CB-12130 > Project: Apache Cordova > Issue Type: Bug > Components: iOS > Affects Versions: Master, 4.3.0 > Reporter: Niels Leenheer > Fix For: cordova-ios@4.3.1 > > > Launch storyboard images were not updated or cleaned in > updateLaunchStoryboardImages() or cleanLaunchStoryboardImages() > because the check for Images.xcassets in > getLaunchStoryboardImagesDir() failed. > The reason was that the platformProjDir and projectRoot were > joined, while both were relative to the root directory. So the > resulting directory was non-sensical. This changes makes > platformProjDir relative to cordovaProject.root, which matches the > same check in updateSplashScreens() and updateIcons(). -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org For additional commands, e-mail: issues-help@cordova.apache.org