Mailing-List: contact issues-help@cordova.apache.org; run by ezmlm
Precedence: bulk
Date: Tue, 1 Nov 2016 08:32:58 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: issues@cordova.apache.org
Message-ID: <JIRA.13015750.1477561081000.141805.1477989178592@Atlassian.JIRA>
In-Reply-To: <JIRA.13015750.1477561081000@Atlassian.JIRA>
References: <JIRA.13015750.1477561081000@Atlassian.JIRA> <JIRA.13015750.1477561081994@arcas>
Subject: [jira] [Commented] (CB-12071) Fix for CB-11825 breaks usage of
 InProcessServer in Cordova Windows
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
archived-at: Tue, 01 Nov 2016 08:33:00 -0000


    [ https://issues.apache.org/jira/browse/CB-12071?page=3Dcom.atlassian.j=
ira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D156247=
49#comment-15624749 ]=20

ASF GitHub Bot commented on CB-12071:
-------------------------------------

GitHub user daserge opened a pull request:

    https://github.com/apache/cordova-windows/pull/208

    CB-12071 Fix for CB-11825 breaks usage of InProcessServer in Cordova =
=E2=80=A6

    =E2=80=A6Windows
    <!--
    Please make sure the checklist boxes are all checked before submitting =
the PR. The checklist
    is intended as a quick reference, for complete details please see our C=
ontributor Guidelines:
   =20
    http://cordova.apache.org/contribute/contribute_guidelines.html
   =20
    Thanks!
    -->
   =20
    ### Platforms affected
    Windows
   =20
    ### What does this PR do?
    Adds a test for missing InProcessServer extension case to prevent furth=
er breakages
   =20
    ### What testing has been done on this change?
    Run npm test, checked that None package action breaks the test.
   =20
    ### Checklist
    - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.h=
tml) in the JIRA database
    - [x] Commit message follows the format: "CB-3232: (android) Fix bug wi=
th resolving file paths", where CB-xxxx is the JIRA ID & "android" is the p=
latform affected.
    - [x] Added automated test coverage as appropriate for this change.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/daserge/cordova-windows CB-12071

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-windows/pull/208.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #208
   =20
----
commit 369f69a0618658209f29027abb1c114761ce5b83
Author: daserge <v-seshak@microsoft.com>
Date:   2016-11-01T08:27:49Z

    CB-12071 Fix for CB-11825 breaks usage of InProcessServer in Cordova Wi=
ndows
   =20
    Adds a test for missing InProcessServer extension case to prevent furth=
er breakages

----


> Fix for CB-11825 breaks usage of InProcessServer in Cordova Windows
> -------------------------------------------------------------------
>
>                 Key: CB-12071
>                 URL: https://issues.apache.org/jira/browse/CB-12071
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Plugins, Windows
>    Affects Versions: 4.4.3
>         Environment: Windows Phone 8.1, Windows 8.1, Windows 10 UWP
>            Reporter: Luc Humair
>            Priority: Critical
>
> I have a plugin which needs an InProcessServerExtension in the project's =
package.windows.appxmanifest like:
> {code:xml}
>     <Extensions>
>         <Extension Category=3D"windows.activatableClass.inProcessServer">
>             <InProcessServer>
>                 <Path>Foo.dll</Path>
>                 <ActivatableClass ActivatableClassId=3D"Foo.Class" Thread=
ingModel=3D"both" />
>             </InProcessServer>
>         </Extension>
>     </Extensions>
> {code}
> The corresponding DLL is configured in the plugin.xml file using:
> {code:xml}
> <resource-file device-target=3D"windows" src=3D"src/windows/win81/$(Platf=
orm)/Foo.dll" target=3D"Foo.dll" versions=3D"8.1"/>
> <resource-file device-target=3D"phone" src=3D"src/windows/wpa81/$(Platfor=
m)/Foo.dll" target=3D"Foo.dll" versions=3D"8.1"/>
> <resource-file src=3D"src/windows/uap/$(Platform)/Foo.dll" target=3D"Foo.=
dll" versions=3D"&gt;=3D10"/>
> {code}
> This configuration worked until release 4.4.2. Foo.dll was included in th=
e projects with property "Package Action"=3D"Content" which includes the DL=
L in the package manifest.
> Release 4.4.3 introduced a patch related to issue CB-11825 that changes  =
the DLL's "Package Action" to "None". Now the file is no longer included in=
 the package manifest and the build fails for all the platforms with the fo=
llowing error message:
> package.windows.appxmanifest : error APPX0703: Manifest references file '=
Foo.dll' which is not part of the payload.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org