Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 80D40200BBC for ; Sun, 13 Nov 2016 17:32:01 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 7F652160B12; Sun, 13 Nov 2016 16:32:01 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id D0A88160AE4 for ; Sun, 13 Nov 2016 17:32:00 +0100 (CET) Received: (qmail 8990 invoked by uid 500); 13 Nov 2016 16:32:00 -0000 Mailing-List: contact issues-help@cordova.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@cordova.apache.org Received: (qmail 8956 invoked by uid 99); 13 Nov 2016 16:32:00 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 13 Nov 2016 16:32:00 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id D0AC52C4C72 for ; Sun, 13 Nov 2016 16:31:59 +0000 (UTC) Date: Sun, 13 Nov 2016 16:31:59 +0000 (UTC) From: "ASF subversion and git services (JIRA)" To: issues@cordova.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CB-9274) InAppBrowser compile error for Amazon FireOS MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Sun, 13 Nov 2016 16:32:01 -0000 [ https://issues.apache.org/jira/browse/CB-9274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15661729#comment-15661729 ] ASF subversion and git services commented on CB-9274: ----------------------------------------------------- Commit 5cbbc8e26ee6f9231b319229eaf75d5e008d5e64 in cordova-plugin-inappbrowser's branch refs/heads/master from ipaterson [ https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-inappbrowser.git;h=5cbbc8e ] CB-9274 Adds missing methods to InAppBrowser to allow compilation for Amazon FireOS. This closes #107 > InAppBrowser compile error for Amazon FireOS > -------------------------------------------- > > Key: CB-9274 > URL: https://issues.apache.org/jira/browse/CB-9274 > Project: Apache Cordova > Issue Type: Bug > Components: Amazon FireOS (deprecated), Plugin InAppBrowser > Affects Versions: 3.5.0 > Reporter: Ian Paterson > Assignee: jcesarmobile > Labels: FireOS, compile-error, patch > > Attempting to compile the InAppBrowser plugin for Amazon FireOS fails due to the following programming errors: > {noformat} > [javac] Compiling 8 source files to /path/to/amazon-fireos/ant-build/classes > [javac] /path/to/amazon-fireos/src/org/apache/cordova/inappbrowser/InAppBrowserDialog.java:51: cannot find symbol > [javac] symbol : method hardwareBack() > [javac] location: class org.apache.cordova.inappbrowser.InAppBrowser > [javac] if (this.inAppBrowser.hardwareBack() && this.inAppBrowser.canGoBack()) { > [javac] ^ > [javac] /path/to/amazon-fireos/src/org/apache/cordova/inappbrowser/InAppBrowserDialog.java:51: cannot find symbol > [javac] symbol : method canGoBack() > [javac] location: class org.apache.cordova.inappbrowser.InAppBrowser > [javac] if (this.inAppBrowser.hardwareBack() && this.inAppBrowser.canGoBack()) { > [javac] ^ > [javac] /path/to/amazon-fireos/src/org/apache/cordova/inappbrowser/InAppBrowserDialog.java:52: goBack() has private access in org.apache.cordova.inappbrowser.InAppBrowser > [javac] this.inAppBrowser.goBack(); > [javac] ^ > [javac] Note: /path/to/amazon-fireos/src/org/apache/cordova/inappbrowser/InAppBrowser.java uses or overrides a deprecated API. > [javac] Note: Recompile with -Xlint:deprecation for details. > [javac] 3 errors > {noformat} > As best I can determine, this problem has existed since plugin version 0.5.2 and was introduced on August 14 in [commit 69ca780772b406ab02ec1bd1a8e4dca70052e926|https://github.com/apache/cordova-plugin-inappbrowser/commit/69ca780772b406ab02ec1bd1a8e4dca70052e926]. Previous commits had diverged the implementation of InAppBrowser.java in Amazon FireOS such that it was no longer compatible with the InAppBrowser.java for Android. > I am preparing a pull request to patch this issue to restore the ability to use the plugin on this platform. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org For additional commands, e-mail: issues-help@cordova.apache.org