cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-12130) Launch storyboard images are not updated or cleaned
Date Wed, 16 Nov 2016 05:24:58 GMT

    [ https://issues.apache.org/jira/browse/CB-12130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15669477#comment-15669477
] 

ASF subversion and git services commented on CB-12130:
------------------------------------------------------

Commit 99219c1c4cd8d1000fb89a15449f2d25a57bef41 in cordova-ios's branch refs/heads/master
from [~NielsLeenheer]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-ios.git;h=99219c1 ]

CB-12130 - Launch storyboard images are not updated or cleaned

The platform project directory needs to be relative to the project

Launch screen images were not updated or cleaned in
`updateLaunchStoryboardImages()` or `cleanLaunchStoryboardImages()`
because the check for `Images.xcassets` in
`getLaunchStoryboardImagesDir()` failed.

The reason was that the `platformProjDir` and `projectRoot` were
joined, while both were relative to the root directory. So the
resulting directory was non-sensical. This changes makes
`platformProjDir` relative to `cordovaProject.root`, which matches the
same check in `updateSplashScreens()` and `updateIcons()`.

 This closes #276


> Launch storyboard images are not updated or cleaned
> ---------------------------------------------------
>
>                 Key: CB-12130
>                 URL: https://issues.apache.org/jira/browse/CB-12130
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: iOS
>    Affects Versions: Master, 4.3.0
>            Reporter: Niels Leenheer
>             Fix For: cordova-ios@4.3.1
>
>
> Launch storyboard images were not updated or cleaned in
> updateLaunchStoryboardImages() or cleanLaunchStoryboardImages()
> because the check for Images.xcassets in
> getLaunchStoryboardImagesDir() failed.
> The reason was that the platformProjDir and projectRoot were
> joined, while both were relative to the root directory. So the
> resulting directory was non-sensical. This changes makes
> platformProjDir relative to cordovaProject.root, which matches the
> same check in updateSplashScreens() and updateIcons().



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message