cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-12124) DeviceCapability not added to windows10 manifest on plugin add
Date Tue, 08 Nov 2016 12:26:58 GMT

    [ https://issues.apache.org/jira/browse/CB-12124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15647428#comment-15647428
] 

ASF GitHub Bot commented on CB-12124:
-------------------------------------

GitHub user matrosov-nikita opened a pull request:

    https://github.com/apache/cordova-windows/pull/209

    CB-12124: Make available device capabilities in package.windows10.appxmanifest

    <!--
    Please make sure the checklist boxes are all checked before submitting the PR. The checklist
    is intended as a quick reference, for complete details please see our Contributor Guidelines:
    
    http://cordova.apache.org/contribute/contribute_guidelines.html
    
    Thanks!
    -->
    
    ### What does this PR do?
    This PR makes available to use device capabilities in package.windows10.appxmanifest.
    
    ### What testing has been done on this change?
    Auto test
    
    ### Checklist
    - [x]  [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA
database
    - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [x] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/matrosov-nikita/cordova-windows CB-12124

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-windows/pull/209.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #209
    
----
commit 74e84e3dc48d6f6a78cc3eb3f170352e3937e0b8
Author: Nikita Matrosov <matrosov.nikita94@gmail.com>
Date:   2016-11-08T12:03:11Z

    CB-12124: Make available device capabilities in package.windows10.appxmanifest

----


> DeviceCapability not added to windows10 manifest on plugin add
> --------------------------------------------------------------
>
>                 Key: CB-12124
>                 URL: https://issues.apache.org/jira/browse/CB-12124
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Windows
>    Affects Versions: 4.4.3
>            Reporter: Sergey Shakhnazarov
>
> {{cordova create test && cd test}}
> {{cordova platform add windows@4.4.3}}
> {{cordova plugin add phonegap-plugin-barcodescanner}}
> {{type platforms\windows\package.windows10.appxmanifest}}
> {code}
>     <Capabilities>
>         <Capability Name="internetClient" />
>     </Capabilities>
> {code}
> {{type platforms\windows\package.windows.appxmanifest}}
> {code}
>     <Capabilities>
>         <Capability Name="internetClient" />
>         <DeviceCapability Name="webcam" />
>     </Capabilities>
> {code}
> plugin.xml:
> {code}
>     <config-file target="package.appxmanifest" parent="/Package/Capabilities">
>       <DeviceCapability Name="webcam"/>
> </config-file>
> {code}
> The issue does not reproduce in cordova-windows@4.4.2



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message