cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-9287) Not enough Icons and Splashscreens for Windows 8.1 and Windows Phone 8.1
Date Tue, 29 Nov 2016 12:10:59 GMT

    [ https://issues.apache.org/jira/browse/CB-9287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15705139#comment-15705139
] 

ASF GitHub Bot commented on CB-9287:
------------------------------------

Github user vladimir-kotikov commented on a diff in the pull request:

    https://github.com/apache/cordova-windows/pull/212#discussion_r89993606
  
    --- Diff: template/cordova/lib/prepare.js ---
    @@ -353,6 +391,13 @@ function mapImageResources(images, imagesDir) {
                     events.emit('warn', 'No images found for target: ' + img.target);
                 } else {
                     candidates.forEach(function(mrtImage) {
    +                    if (img.target === SPLASH_SCREEN_DESKTOP_TARGET_NAME &&
    +                        mrtSplashScreenToTargetProject(mrtImage) === TARGET_PROJECT_10
&&
    +                        exceedsSizeLimit(mrtImage.path)) {
    --- End diff --
    
    Makes sense


> Not enough Icons and Splashscreens for Windows 8.1 and Windows Phone 8.1
> ------------------------------------------------------------------------
>
>                 Key: CB-9287
>                 URL: https://issues.apache.org/jira/browse/CB-9287
>             Project: Apache Cordova
>          Issue Type: Improvement
>          Components: Plugin SplashScreen, Windows
>    Affects Versions: 4.0.0
>         Environment: Cordova 4.0.0, Windows Platform 3.7.1
>            Reporter: Dennis Patzer
>            Assignee: Jesse MacFadyen
>              Labels: triaged, windows
>         Attachments: splashscreens_windows_universal_app.jpg
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> For some reason, for example only one splashscreen size is supported (620x300). When
I add other sizes by adding the following line:
> <splash src="../resources/themes/windows-phone/img/splashscreen/splashscreen.scale-140.png"
width="868" height="420" />
> The image isn't copied to the cordova/platforms/windows/images folder when building.
This is the reason why it's also not included and referenced in the resulting package.windows.appxmanifest.
> Why is that?? Or am I doing something wrong?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message