cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-9287) Not enough Icons and Splashscreens for Windows 8.1 and Windows Phone 8.1
Date Fri, 25 Nov 2016 10:40:58 GMT

    [ https://issues.apache.org/jira/browse/CB-9287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15695542#comment-15695542
] 

ASF GitHub Bot commented on CB-9287:
------------------------------------

Github user codecov-io commented on the issue:

    https://github.com/apache/cordova-windows/pull/212
  
    ## [Current coverage](https://codecov.io/gh/apache/cordova-windows/pull/212?src=pr) is
76.04% (diff: 95.69%)
    > Merging [#212](https://codecov.io/gh/apache/cordova-windows/pull/212?src=pr) into
[master](https://codecov.io/gh/apache/cordova-windows/branch/master?src=pr) will increase
coverage by **0.76%**
    
    ```diff
    @@             master       #212   diff @@
    ==========================================
      Files            16         16          
      Lines          2120       2200    +80   
      Methods         401        415    +14   
      Messages          0          0          
      Branches        410        430    +20   
    ==========================================
    + Hits           1596       1673    +77   
    - Misses          524        527     +3   
      Partials          0          0          
    ```
    
    > Powered by [Codecov](https://codecov.io?src=pr). Last update [09d582c...bd0096b](https://codecov.io/gh/apache/cordova-windows/compare/09d582c8705625bbdcd8fb97c30c02eea04d14b0...bd0096b71a3d6d65169d7d4582e50a05dc48ecb0?src=pr)


> Not enough Icons and Splashscreens for Windows 8.1 and Windows Phone 8.1
> ------------------------------------------------------------------------
>
>                 Key: CB-9287
>                 URL: https://issues.apache.org/jira/browse/CB-9287
>             Project: Apache Cordova
>          Issue Type: Improvement
>          Components: Plugin SplashScreen, Windows
>    Affects Versions: 4.0.0
>         Environment: Cordova 4.0.0, Windows Platform 3.7.1
>            Reporter: Dennis Patzer
>            Assignee: Jesse MacFadyen
>              Labels: triaged, windows
>         Attachments: splashscreens_windows_universal_app.jpg
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> For some reason, for example only one splashscreen size is supported (620x300). When
I add other sizes by adding the following line:
> <splash src="../resources/themes/windows-phone/img/splashscreen/splashscreen.scale-140.png"
width="868" height="420" />
> The image isn't copied to the cordova/platforms/windows/images folder when building.
This is the reason why it's also not included and referenced in the resulting package.windows.appxmanifest.
> Why is that?? Or am I doing something wrong?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message