cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-9287) Not enough Icons and Splashscreens for Windows 8.1 and Windows Phone 8.1
Date Fri, 25 Nov 2016 10:33:58 GMT

    [ https://issues.apache.org/jira/browse/CB-9287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15695525#comment-15695525
] 

ASF GitHub Bot commented on CB-9287:
------------------------------------

GitHub user daserge opened a pull request:

    https://github.com/apache/cordova-windows/pull/212

    CB-9287 Not enough Icons and Splashscreens for Windows 8.1 and Windows Phone 8.1

    <!--
    Please make sure the checklist boxes are all checked before submitting the PR. The checklist
    is intended as a quick reference, for complete details please see our Contributor Guidelines:
    
    http://cordova.apache.org/contribute/contribute_guidelines.html
    
    Thanks!
    -->
    
    ### Platforms affected
    Windows
    
    ### What does this PR do?
    Add JPG support, added missing splashscreen scales for projects
    cordova.js - refine splashscreen extension based on config.xml
    Added a warning when non-MRT splash screens have mixed extensions
    Added a warning for size limit exceeding (applies to win10 project only)
    Added a warning for images with unsupported format
    Tests
    
    [Jira issue CB-9287](https://issues.apache.org/jira/browse/CB-9287)
    
    ### What testing has been done on this change?
    Manual and auto tests
    
    ### Checklist
    - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA
database
    - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [x] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/daserge/cordova-windows CB-9287

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-windows/pull/212.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #212
    
----
commit d4640969dc2b9b7b5322629a899c040fb9496a26
Author: daserge <v-seshak@microsoft.com>
Date:   2016-11-25T10:30:46Z

    CB-9287 Not enough Icons and Splashscreens for Windows 8.1 and Windows Phone 8.1
    
    Add JPG support
    cordova.js - refine splashscreen extension based on config.xml
    Added a warning when non-MRT splash screens have mixed extensions
    Added a warning for size limit exceeding (applies to win10 project only)
    Added a warning for images with unsupported format

commit bd0096b71a3d6d65169d7d4582e50a05dc48ecb0
Author: daserge <v-seshak@microsoft.com>
Date:   2016-11-25T10:31:03Z

    CB-9287 Not enough Icons and Splashscreens for Windows 8.1 and Windows Phone 8.1
    
    Tests

----


> Not enough Icons and Splashscreens for Windows 8.1 and Windows Phone 8.1
> ------------------------------------------------------------------------
>
>                 Key: CB-9287
>                 URL: https://issues.apache.org/jira/browse/CB-9287
>             Project: Apache Cordova
>          Issue Type: Improvement
>          Components: Plugin SplashScreen, Windows
>    Affects Versions: 4.0.0
>         Environment: Cordova 4.0.0, Windows Platform 3.7.1
>            Reporter: Dennis Patzer
>            Assignee: Jesse MacFadyen
>              Labels: triaged, windows
>         Attachments: splashscreens_windows_universal_app.jpg
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> For some reason, for example only one splashscreen size is supported (620x300). When
I add other sizes by adding the following line:
> <splash src="../resources/themes/windows-phone/img/splashscreen/splashscreen.scale-140.png"
width="868" height="420" />
> The image isn't copied to the cordova/platforms/windows/images folder when building.
This is the reason why it's also not included and referenced in the resulting package.windows.appxmanifest.
> Why is that?? Or am I doing something wrong?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message