Return-Path: <issues-return-74060-archive-asf-public=cust-asf.ponee.io@cordova.apache.org>
X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io
Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io
Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183])
	by cust-asf2.ponee.io (Postfix) with ESMTP id 8AE1B200BC4
	for <archive-asf-public-internal@cust-asf2.ponee.io>; Sat, 15 Oct 2016 02:57:22 +0200 (CEST)
Received: by cust-asf.ponee.io (Postfix)
	id 89729160ADD; Sat, 15 Oct 2016 00:57:22 +0000 (UTC)
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by cust-asf.ponee.io (Postfix) with SMTP id D827B160AE3
	for <archive-asf-public@cust-asf.ponee.io>; Sat, 15 Oct 2016 02:57:21 +0200 (CEST)
Received: (qmail 13378 invoked by uid 500); 15 Oct 2016 00:57:21 -0000
Mailing-List: contact issues-help@cordova.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:issues-help@cordova.apache.org>
List-Unsubscribe: <mailto:issues-unsubscribe@cordova.apache.org>
List-Post: <mailto:issues@cordova.apache.org>
List-Id: <issues.cordova.apache.org>
Delivered-To: mailing list issues@cordova.apache.org
Received: (qmail 13315 invoked by uid 99); 15 Oct 2016 00:57:20 -0000
Received: from arcas.apache.org (HELO arcas) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 15 Oct 2016 00:57:20 +0000
Received: from arcas.apache.org (localhost [127.0.0.1])
	by arcas (Postfix) with ESMTP id B32FA2C4C73
	for <issues@cordova.apache.org>; Sat, 15 Oct 2016 00:57:20 +0000 (UTC)
Date: Sat, 15 Oct 2016 00:57:20 +0000 (UTC)
From: "ASF subversion and git services (JIRA)" <jira@apache.org>
To: issues@cordova.apache.org
Message-ID: <JIRA.13009572.1475591313000.837823.1476493040730@Atlassian.JIRA>
In-Reply-To: <JIRA.13009572.1475591313000@Atlassian.JIRA>
References: <JIRA.13009572.1475591313000@Atlassian.JIRA> <JIRA.13009572.1475591313290@arcas>
Subject: [jira] [Commented] (CB-11951) Plugin preference default value is
 not being saved to <platform>.json
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394
archived-at: Sat, 15 Oct 2016 00:57:22 -0000


    [ https://issues.apache.org/jira/browse/CB-11951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15577042#comment-15577042 ] 

ASF subversion and git services commented on CB-11951:
------------------------------------------------------

Commit afcffc59ad186ae98518ac890fd942d3ca7069d8 in cordova-lib's branch refs/heads/master from [~Nikita Matrosov]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;h=afcffc5 ]

CB-11951 CB-11967: Respect preference default values when install plugin


> Plugin preference default value is not being saved to <platform>.json
> ---------------------------------------------------------------------
>
>                 Key: CB-11951
>                 URL: https://issues.apache.org/jira/browse/CB-11951
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: CLI, CordovaLib
>    Affects Versions: 6.3.1
>         Environment: Windows 10 with anniversary update
>            Reporter: Alexander Sorokin
>            Assignee: Nikita Matrosov
>
> Plugin preference default value is not being saved to <platform>.json
> {noformat}
> cordova create foo
> cd foo
> cordova platform add android
> cordova plugin add cordova-plugin-ms-azure-mobile-engagement --variable AZME_ANDROID_CONNECTION_STRING=Endpoint=0;AppId=0;SdkKey=0 --variable AZME_ENABLE_PLUGIN_LOG=false
> {noformat}
> check out `./platforms/android/android.json` or `./pluguns/android.json`
> it has the following lines:
> {code}
> "installed_plugins": {
>         <...>
>         "cordova-plugin-ms-azure-mobile-engagement": {
>             "AZME_ENABLE_PLUGIN_LOG": "false",
>             "AZME_ANDROID_GOOGLE_PROJECT_NUMBER": "null",
>             "AZME_ANDROID_REACH_ICON": "icon",
>             "AZME_ANDROID_CONNECTION_STRING": "Endpoint=0;AppId=0;SdkKey=0",
>             "PACKAGE_NAME": "io.cordova.hellocordova"
>         }
>     },
> {code}
> You can see that "AZME_ENABLE_PLUGIN_LOG" is saved here, while "AZME_ENABLE_NATIVE_LOG" is not.
> They both can be found in the plugin section of the  plugin's `plugin.xml` file:
> https://github.com/Azure/azure-mobile-engagement-cordova/blob/master/plugin.xml#L29
> Note that the Android-specific preferences have been saved correctly.
> cordova@6.3.0 doesn't have this issue.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org