Return-Path: <issues-return-74119-archive-asf-public=cust-asf.ponee.io@cordova.apache.org>
X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io
Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io
Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183])
	by cust-asf2.ponee.io (Postfix) with ESMTP id 95728200BB4
	for <archive-asf-public-internal@cust-asf2.ponee.io>; Mon, 17 Oct 2016 13:56:02 +0200 (CEST)
Received: by cust-asf.ponee.io (Postfix)
	id 93D61160AE5; Mon, 17 Oct 2016 11:56:02 +0000 (UTC)
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by cust-asf.ponee.io (Postfix) with SMTP id E5054160AEC
	for <archive-asf-public@cust-asf.ponee.io>; Mon, 17 Oct 2016 13:56:01 +0200 (CEST)
Received: (qmail 60128 invoked by uid 500); 17 Oct 2016 11:56:00 -0000
Mailing-List: contact issues-help@cordova.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:issues-help@cordova.apache.org>
List-Unsubscribe: <mailto:issues-unsubscribe@cordova.apache.org>
List-Post: <mailto:issues@cordova.apache.org>
List-Id: <issues.cordova.apache.org>
Delivered-To: mailing list issues@cordova.apache.org
Received: (qmail 59178 invoked by uid 99); 17 Oct 2016 11:55:59 -0000
Received: from arcas.apache.org (HELO arcas) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 17 Oct 2016 11:55:59 +0000
Received: from arcas.apache.org (localhost [127.0.0.1])
	by arcas (Postfix) with ESMTP id BB0C62C4C76
	for <issues@cordova.apache.org>; Mon, 17 Oct 2016 11:55:58 +0000 (UTC)
Date: Mon, 17 Oct 2016 11:55:58 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: issues@cordova.apache.org
Message-ID: <JIRA.13008487.1475143208000.3210.1476705358762@Atlassian.JIRA>
In-Reply-To: <JIRA.13008487.1475143208000@Atlassian.JIRA>
References: <JIRA.13008487.1475143208000@Atlassian.JIRA> <JIRA.13008487.1475143208143@arcas>
Subject: [jira] [Commented] (CB-11933) [windows] uap: not added on plugin
 add
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394
archived-at: Mon, 17 Oct 2016 11:56:02 -0000


    [ https://issues.apache.org/jira/browse/CB-11933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15582018#comment-15582018 ] 

ASF GitHub Bot commented on CB-11933:
-------------------------------------

Github user vladimir-kotikov commented on the issue:

    https://github.com/apache/cordova-windows/pull/202
  
    LGTM


> [windows] uap: not added on plugin add
> --------------------------------------
>
>                 Key: CB-11933
>                 URL: https://issues.apache.org/jira/browse/CB-11933
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Windows
>            Reporter: Sergey Shakhnazarov
>            Assignee: Nikita Matrosov
>
> {noformat}
> cordova create test
> cd test
> cordova platform add https://github.com/apache/cordova-windows
> cordova plugin add https://github.com/AzureAD/azure-activedirectory-library-for-cordova
> cordova plugin add plugins\cordova-plugin-ms-adal\src\windows\sso\
> type platforms\windows\package.windows10.appxmanifest
> {noformat}
> ->
> {noformat}
>     <Capabilities>
>         <Capability Name="internetClient" />
>         <Capability Name="enterpriseAuthentication" />
>         <Capability Name="privateNetworkClientServer" />
>         <Capability Name="sharedUserCertificates" />
>     </Capabilities>
> {noformat}
> {{cordova prepare}}
> {noformat}
> type platforms\windows\package.windows10.appxmanifest
> {noformat}
> {noformat}
>     <Capabilities>
>         <Capability Name="internetClient" />
>         <uap:Capability Name="enterpriseAuthentication" />
>         <Capability Name="privateNetworkClientServer" />
>         <uap:Capability Name="sharedUserCertificates" />
>     </Capabilities>
> {noformat}
> {{cordova plugin rm cordova-plugin-ms-adal-sso}}
> {noformat}
> type platforms\windows\package.windows10.appxmanifest
> {noformat}
> {noformat}
>     <Capabilities>
>         <Capability Name="internetClient" />
>         <uap:Capability Name="enterpriseAuthentication" />
>         <uap:Capability Name="sharedUserCertificates" />
>     </Capabilities>
> {noformat}
> 1. uap: prefixes not being added on plugin add
> 2. cordova prepare fixes this
> 3. plugin rm does not remove added capabilities as they have been changed
> cordova-plugin-ms-adal-sso plugin.xml:
> {noformat}
>     <platform name="windows">
>         <js-module name="overrides" src="www/overrides.js">
>             <runs />
>         </js-module>
>         <config-file target="package.appxmanifest" parent="/Package/Capabilities" device-target="windows">
>             <Capability Name="enterpriseAuthentication" />
>             <Capability Name="privateNetworkClientServer" />
>             <Capability Name="sharedUserCertificates" />
>         </config-file>
>     </platform>
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org