cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-11979) add deprecation notice for using subdirectory syntax when fetching plugins
Date Thu, 20 Oct 2016 17:31:58 GMT

    [ https://issues.apache.org/jira/browse/CB-11979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15592430#comment-15592430
] 

ASF GitHub Bot commented on CB-11979:
-------------------------------------

Github user sterlingann commented on a diff in the pull request:

    https://github.com/apache/cordova-lib/pull/504#discussion_r84335445
  
    --- Diff: cordova-lib/src/plugman/fetch.js ---
    @@ -68,9 +68,13 @@ function fetchPlugin(plugin_src, plugins_dir, options) {
                 if (result[2])
                     options.subdir = result[2];
                 //if --fetch was used, throw error for subdirectories
    -            if (result[2] && options.fetch) {
    -                return Q.reject(new CordovaError('--fetch does not support subdirectories'));
    -            }
    +        
    +        if(options.subdir) {
    +            events.emit('warn', 'support for subdirectories is depreated and will be
removed in Cordova@7');
    --- End diff --
    
    Thank you Vladimir!  I'm an intern, this is my first pull request.  I appreciate the feedback
:) I will fix it now...


> add deprecation notice for using subdirectory syntax when fetching plugins
> --------------------------------------------------------------------------
>
>                 Key: CB-11979
>                 URL: https://issues.apache.org/jira/browse/CB-11979
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: CordovaLib
>    Affects Versions: 6.3.1
>            Reporter: Steve Gill
>            Assignee: sterling gerritz
>              Labels: cordova-7.0.0
>             Fix For: 6.4.0
>
>
> We plan to remove subdirectory syntax in cordova@7 since `--fetch` can't support it.

> Need to add a deprecation to the next cordova@6.x release to start warning folks it is
going away.
> You can see the subdirectory syntax at http://cordova.apache.org/docs/en/latest/reference/cordova-cli/index.html#plugin-spec.
> I think it is plugin specific, but need to double check it is not supported for fetching
platforms too. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message