cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-11976) Add deprecated node version warning for 0.x
Date Mon, 10 Oct 2016 07:55:20 GMT

    [ https://issues.apache.org/jira/browse/CB-11976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15561582#comment-15561582
] 

ASF GitHub Bot commented on CB-11976:
-------------------------------------

GitHub user shazron opened a pull request:

    https://github.com/apache/cordova-cli/pull/262

    CB-11976 - Add deprecated node version warning for 0.x

    ### Platforms affected
    
    All.
    
    ### What does this PR do?
    
    Before running each command, it will check if the node version is 0.x. If it is, it prints
out a warning.
    
    ### What testing has been done on this change?
    
    Tested locally.
    
    ### Checklist
    - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA
database
    - [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/shazron/cordova-cli CB-11976

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-cli/pull/262.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #262
    
----
commit 0814fe06c7851103ea321873cd160b47481596cd
Author: Shazron Abdullah <shazron@apache.org>
Date:   2016-10-10T07:53:58Z

    CB-11976 - Add deprecated node version warning for 0.x

----


> Add deprecated node version warning for 0.x
> -------------------------------------------
>
>                 Key: CB-11976
>                 URL: https://issues.apache.org/jira/browse/CB-11976
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: CordovaLib
>            Reporter: Shazron Abdullah
>            Assignee: Shazron Abdullah
>              Labels: cordova-7.0.0
>
> Put in the promise chain of prepare:
> https://github.com/apache/cordova-lib/blob/f8b58c782c71558516adbbd81929ee31ec3ded7f/cordova-lib/src/cordova/prepare.js
> Model it after this:
> https://github.com/apache/cordova-lib/blob/f8b58c782c71558516adbbd81929ee31ec3ded7f/cordova-lib/src/cordova/platform.js#L144-L150
> Check "process.version" for v0.x.x or v0.x, if they exist, print the warning.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message