cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-11951) Plugin preference default value is not being saved to <platform>.json
Date Wed, 12 Oct 2016 10:43:20 GMT

    [ https://issues.apache.org/jira/browse/CB-11951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15568363#comment-15568363
] 

ASF GitHub Bot commented on CB-11951:
-------------------------------------

GitHub user matrosov-nikita opened a pull request:

    https://github.com/apache/cordova-lib/pull/501

    CB-11951 CB-11990 CB-11967: Respect preference default values when install plugin

    <!--
    Please make sure the checklist boxes are all checked before submitting the PR. The checklist
    is intended as a quick reference, for complete details please see our Contributor Guidelines:
    
    http://cordova.apache.org/contribute/contribute_guidelines.html
    
    Thanks!
    -->
    
    ### What does this PR do?
    Respects preference default values when install plugin
    
    ### What testing has been done on this change?
    Auto test
    
    ### Checklist
    - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA
database
    - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [x] Added automated test coverage as appropriate for this change.
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/matrosov-nikita/cordova-lib CB-11951

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-lib/pull/501.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #501
    
----
commit 51e171a4a3802fe693de4603a08a3584e302e19c
Author: Nikita Matrosov <matrosov.nikita94@gmail.com>
Date:   2016-10-12T10:39:35Z

    CB-11951 CB-11990 CB-11967: Respect preference default values when install plugin

----


> Plugin preference default value is not being saved to <platform>.json
> ---------------------------------------------------------------------
>
>                 Key: CB-11951
>                 URL: https://issues.apache.org/jira/browse/CB-11951
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: CLI, CordovaLib
>    Affects Versions: 6.3.1
>         Environment: Windows 10 with anniversary update
>            Reporter: Alexander Sorokin
>
> Plugin preference default value is not being saved to <platform>.json
> {noformat}
> cordova create foo
> cd foo
> cordova platform add android
> cordova plugin add cordova-plugin-ms-azure-mobile-engagement --variable AZME_ANDROID_CONNECTION_STRING=Endpoint=0;AppId=0;SdkKey=0
--variable AZME_ENABLE_PLUGIN_LOG=false
> {noformat}
> check out `./platforms/android/android.json` or `./pluguns/android.json`
> it has the following lines:
> {code}
> "installed_plugins": {
>         <...>
>         "cordova-plugin-ms-azure-mobile-engagement": {
>             "AZME_ENABLE_PLUGIN_LOG": "false",
>             "AZME_ANDROID_GOOGLE_PROJECT_NUMBER": "null",
>             "AZME_ANDROID_REACH_ICON": "icon",
>             "AZME_ANDROID_CONNECTION_STRING": "Endpoint=0;AppId=0;SdkKey=0",
>             "PACKAGE_NAME": "io.cordova.hellocordova"
>         }
>     },
> {code}
> You can see that "AZME_ENABLE_PLUGIN_LOG" is saved here, while "AZME_ENABLE_NATIVE_LOG"
is not.
> They both can be found in the plugin section of the  plugin's `plugin.xml` file:
> https://github.com/Azure/azure-mobile-engagement-cordova/blob/master/plugin.xml#L29
> Note that the Android-specific preferences have been saved correctly.
> cordova@6.3.0 doesn't have this issue.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message