cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-11933) [windows] uap: not added on plugin add
Date Wed, 19 Oct 2016 11:26:58 GMT

    [ https://issues.apache.org/jira/browse/CB-11933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15588482#comment-15588482
] 

ASF GitHub Bot commented on CB-11933:
-------------------------------------

GitHub user matrosov-nikita opened a pull request:

    https://github.com/apache/cordova-windows/pull/203

    CB-11933: Add uap prefixes for capabilities from package.windows10.appxmanifest when installing
plugin

    <!--
    Please make sure the checklist boxes are all checked before submitting the PR. The checklist
    is intended as a quick reference, for complete details please see our Contributor Guidelines:
    
    http://cordova.apache.org/contribute/contribute_guidelines.html
    
    Thanks!
    -->
    
    ### What does this PR do?
    Windows has a special logic for adding appxmanifest's capabilities. This PR adds uap prefixes
to capabilities from package.windows10.appxmanifest when installing plugin.
    
    ### What testing has been done on this change?
    Auto test
    
    ### Checklist
    - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA
database
    - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [x] Added automated test coverage as appropriate for this change.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/matrosov-nikita/cordova-windows CB-11933-add

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-windows/pull/203.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #203
    
----

----


> [windows] uap: not added on plugin add
> --------------------------------------
>
>                 Key: CB-11933
>                 URL: https://issues.apache.org/jira/browse/CB-11933
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Windows
>            Reporter: Sergey Shakhnazarov
>            Assignee: Nikita Matrosov
>
> {noformat}
> cordova create test
> cd test
> cordova platform add https://github.com/apache/cordova-windows
> cordova plugin add https://github.com/AzureAD/azure-activedirectory-library-for-cordova
> cordova plugin add plugins\cordova-plugin-ms-adal\src\windows\sso\
> type platforms\windows\package.windows10.appxmanifest
> {noformat}
> ->
> {noformat}
>     <Capabilities>
>         <Capability Name="internetClient" />
>         <Capability Name="enterpriseAuthentication" />
>         <Capability Name="privateNetworkClientServer" />
>         <Capability Name="sharedUserCertificates" />
>     </Capabilities>
> {noformat}
> {{cordova prepare}}
> {noformat}
> type platforms\windows\package.windows10.appxmanifest
> {noformat}
> {noformat}
>     <Capabilities>
>         <Capability Name="internetClient" />
>         <uap:Capability Name="enterpriseAuthentication" />
>         <Capability Name="privateNetworkClientServer" />
>         <uap:Capability Name="sharedUserCertificates" />
>     </Capabilities>
> {noformat}
> {{cordova plugin rm cordova-plugin-ms-adal-sso}}
> {noformat}
> type platforms\windows\package.windows10.appxmanifest
> {noformat}
> {noformat}
>     <Capabilities>
>         <Capability Name="internetClient" />
>         <uap:Capability Name="enterpriseAuthentication" />
>         <uap:Capability Name="sharedUserCertificates" />
>     </Capabilities>
> {noformat}
> 1. uap: prefixes not being added on plugin add
> 2. cordova prepare fixes this
> 3. plugin rm does not remove added capabilities as they have been changed
> cordova-plugin-ms-adal-sso plugin.xml:
> {noformat}
>     <platform name="windows">
>         <js-module name="overrides" src="www/overrides.js">
>             <runs />
>         </js-module>
>         <config-file target="package.appxmanifest" parent="/Package/Capabilities"
device-target="windows">
>             <Capability Name="enterpriseAuthentication" />
>             <Capability Name="privateNetworkClientServer" />
>             <Capability Name="sharedUserCertificates" />
>         </config-file>
>     </platform>
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message