cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-11926) File-transfer tests should be able to use local file server
Date Tue, 04 Oct 2016 09:54:20 GMT

    [ https://issues.apache.org/jira/browse/CB-11926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15544939#comment-15544939
] 

ASF GitHub Bot commented on CB-11926:
-------------------------------------

Github user vladimir-kotikov commented on a diff in the pull request:

    https://github.com/apache/cordova-plugin-file-transfer/pull/159#discussion_r81722419
  
    --- Diff: tests/hooks/after_prepare.js ---
    @@ -0,0 +1,71 @@
    +#!/usr/bin/env node
    +
    +/*
    +*
    +* Licensed to the Apache Software Foundation (ASF) under one
    +* or more contributor license agreements.  See the NOTICE file
    +* distributed with this work for additional information
    +* regarding copyright ownership.  The ASF licenses this file
    +* to you under the Apache License, Version 2.0 (the
    +* "License"); you may not use this file except in compliance
    +* with the License.  You may obtain a copy of the License at
    +*
    +*   http://www.apache.org/licenses/LICENSE-2.0
    +*
    +* Unless required by applicable law or agreed to in writing,
    +* software distributed under the License is distributed on an
    +* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    +* KIND, either express or implied.  See the License for the
    +* specific language governing permissions and limitations
    +* under the License.
    +*
    +*/
    +
    +var path = require('path');
    +var fs = require('fs');
    +
    +module.exports = function(context) {
    +    function main() {
    +        // get the file transfer server address from the specified variables
    +        var defaultFileTransferServerAddress = getDefaultFileTransferServerAddress(context);
    +        var fileTransferServerAddress = getFileTransferServerAddress(context) || defaultFileTransferServerAddress;
    +        console.log('Tests will use the following file transfer server address: ' + fileTransferServerAddress);
    +
    +        // pass it to the tests
    +        writeFileTransferOptions(fileTransferServerAddress, context);
    +    }
    +
    +    function getDefaultFileTransferServerAddress(context) {
    --- End diff --
    
    This is odd, because after running this: `cordova plugin add https://github.com/alsorokin/cordova-plugin-file-transfer#ca293bd3f29dc74f628721a552ff91593380d81e:tests`
_(notice that i didn't specify any variables)_, i can see these lines in `platforms/windows/windows.json`:
    ```json
            "cordova-plugin-file-transfer-tests": {
                "FILETRANSFER_SERVER_ADDRESS": "http://cordova-vm.apache.org:5000",
                "PACKAGE_NAME": "HelloCordova"
            }
    ```
    
    Could you please double-check


> File-transfer tests should be able to use local file server
> -----------------------------------------------------------
>
>                 Key: CB-11926
>                 URL: https://issues.apache.org/jira/browse/CB-11926
>             Project: Apache Cordova
>          Issue Type: Test
>          Components: Paramedic, Plugin File Transfer
>            Reporter: Alexander Sorokin
>            Assignee: Alexander Sorokin
>            Priority: Minor
>              Labels: triaged
>
> File-transfer tests should be able to use locally running file server instead of relying
only on Apache infrastructure.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message