cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-11729) template file MainViewController.m has deprecated override shouldAutorotateToInterfaceOrientation
Date Fri, 07 Oct 2016 23:29:20 GMT

    [ https://issues.apache.org/jira/browse/CB-11729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15556595#comment-15556595
] 

ASF GitHub Bot commented on CB-11729:
-------------------------------------

GitHub user shazron opened a pull request:

    https://github.com/apache/cordova-ios/pull/266

    CB-11729 - template file MainViewController.m has deprecated override shouldAutorotateToInterfaceOrientation

    ### Platforms affected
    iOS
    
    ### What does this PR do?
    
    Remove unused selector in MainViewController subclass, add in comments the new overrides
available.
    
    ### What testing has been done on this change?
    
    Local build
    
    ### Checklist
    - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA
database
    - [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/shazron/cordova-ios CB-11729

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-ios/pull/266.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #266
    
----
commit d71cb97fa31c8e59df10dffa3fc6cb927e2deb42
Author: Shazron Abdullah <shazron@apache.org>
Date:   2016-10-07T23:26:36Z

    CB-11729 - template file MainViewController.m has deprecated override shouldAutorotateToInterfaceOrientation

----


> template file MainViewController.m has deprecated override shouldAutorotateToInterfaceOrientation
> -------------------------------------------------------------------------------------------------
>
>                 Key: CB-11729
>                 URL: https://issues.apache.org/jira/browse/CB-11729
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: iOS
>            Reporter: Shazron Abdullah
>            Assignee: Shazron Abdullah
>
> shouldAutorotateToInterfaceOrientation has been deprecated since iOS 6, and is never
called anymore.
> The new function is should be shouldAutoRotate. Use any of the three here as overrides:
https://github.com/apache/cordova-ios/blob/f75bf67438257132e739238ed579d73271b3a716/CordovaLib/Classes/Public/CDVScreenOrientationDelegate.h



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message