cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-3232) "cordova platform add blackberry" fails on 2.7.1-rc.1
Date Thu, 13 Oct 2016 11:54:21 GMT

    [ https://issues.apache.org/jira/browse/CB-3232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15571699#comment-15571699
] 

ASF GitHub Bot commented on CB-3232:
------------------------------------

GitHub user Webpal opened a pull request:

    https://github.com/apache/cordova-plugin-file-transfer/pull/161

    Allowing chunkedMode to be false on Android / https

    <!--
    Please make sure the checklist boxes are all checked before submitting the PR. The checklist
    is intended as a quick reference, for complete details please see our Contributor Guidelines:
    
    http://cordova.apache.org/contribute/contribute_guidelines.html
    
    Thanks!
    -->
    
    ### Platforms affected
    Android
    
    ### What does this PR do?
    File uploads over https were automatically turned to Transfer-encoding: chunked due to
old Android issues. Since adding this header to transfers often breaks functionality (for
example you can't add an additional header to an Amazon S3 request that was signed without
it) - isn't it better to follow the users instruction to use chunked mode or not instead of
overwriting it? 
    
    ### What testing has been done on this change?
    Only deployed on one Android device, can not verify that it doesn't cause OOM issues -
but this option is available as a setting for the user to controll in js.
    
    ### Checklist
    - [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA
database
    - [ ] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [ ] Added automated test coverage as appropriate for this change.
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/Webpal/cordova-plugin-file-transfer master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-file-transfer/pull/161.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #161
    
----
commit e836377a0ff6e2fda810f65a8220413b2095a3ec
Author: Webpal <niklas@webpal.se>
Date:   2016-10-13T11:44:11Z

    Update FileTransfer.java

----


> "cordova platform add blackberry" fails on 2.7.1-rc.1
> -----------------------------------------------------
>
>                 Key: CB-3232
>                 URL: https://issues.apache.org/jira/browse/CB-3232
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: BlackBerry, CLI
>    Affects Versions: 2.7.0
>            Reporter: Michael Brooks
>            Assignee: Michael Brooks
>             Fix For: 2.7.0
>
>
> The following error is thrown when running {{$ cordova platform add blackberry}}:
> {code}
> [Error: An error occured during creation of blackberry sub-project. Creating BlackBerry
project...
> Updating config.xml ...
> sed: /Users/mwbrooks/Dropbox/Development/sandbox/myapp/platforms/blackberry/www/config.xml:
No such file or directory
> Cleaning up ...
> Remember to update the project.properties file inside your application directory!
> ]
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message