Mailing-List: contact issues-help@cordova.apache.org; run by ezmlm
Precedence: bulk
Date: Sun, 4 Sep 2016 01:23:22 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: issues@cordova.apache.org
Message-ID: <JIRA.13002590.1472951947000.487497.1472952202037@Atlassian.JIRA>
In-Reply-To: <JIRA.13002590.1472951947000@Atlassian.JIRA>
References: <JIRA.13002590.1472951947000@Atlassian.JIRA> <JIRA.13002590.1472951947220@arcas>
Subject: [jira] [Commented] (CB-11804) inappbrowser plugin for ios doesnt
 look consistent with iOS style
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Sun, 04 Sep 2016 01:23:24 -0000


    [ https://issues.apache.org/jira/browse/CB-11804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15462016#comment-15462016 ] 

ASF GitHub Bot commented on CB-11804:
-------------------------------------

GitHub user dmvjs opened a pull request:

    https://github.com/apache/cordova-plugin-inappbrowser/pull/185

    iOS friendlier UI

    https://issues.apache.org/jira/browse/CB-11804
    inappbrowser plugin for ios doesnt look consistent with iOS style
    
    ### Platforms affected
    iOS only
    
    ### What does this PR do?
    makes the UI more iOS friendly
    
    ### What testing has been done on this change?
    I have been using this UI for over three years in several apps for a large publisher. it's a UI change but it makes a big difference IMO
    
    ### Checklist
    - [X ] [ICLA](http://www.apache.org/licenses/icla.txt) has been signed and submitted to secretary@apache.org.
    - [X ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
    - [0 ] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [0 ] Added automated test coverage as appropriate for this change.
    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dmvjs/cordova-plugin-inappbrowser master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-inappbrowser/pull/185.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #185
    
----
commit 424e838d21cd1c00f2393eebdc090a8e0e3a3576
Author: Kirk Elliott <kirk@addthis.com>
Date:   2016-09-04T01:07:52Z

    iOS friendlier UI

----


> inappbrowser plugin for ios doesnt look consistent with iOS style
> -----------------------------------------------------------------
>
>                 Key: CB-11804
>                 URL: https://issues.apache.org/jira/browse/CB-11804
>             Project: Apache Cordova
>          Issue Type: Improvement
>      Security Level: Public(Anyone can view this level - this is the default.) 
>          Components: Plugin InAppBrowser
>    Affects Versions: 3.5.0
>            Reporter: Kirk ELliott
>            Priority: Trivial
>             Fix For: Master
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> It doesn't look like iOS at all and I have been patching the UI for years so I am finally sharing the wealth.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org