Mailing-List: contact issues-help@cordova.apache.org; run by ezmlm
Precedence: bulk
Date: Wed, 21 Sep 2016 08:33:20 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: issues@cordova.apache.org
Message-ID: <JIRA.12996742.1470944218000.624576.1474446800913@Atlassian.JIRA>
In-Reply-To: <JIRA.12996742.1470944218000@Atlassian.JIRA>
References: <JIRA.12996742.1470944218000@Atlassian.JIRA> <JIRA.12996742.1470944218241@arcas>
Subject: [jira] [Commented] (CB-11694) hardwareback value persists across
 usages
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
archived-at: Wed, 21 Sep 2016 08:33:27 -0000


    [ https://issues.apache.org/jira/browse/CB-11694?page=3Dcom.atlassian.j=
ira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D155092=
07#comment-15509207 ]=20

ASF GitHub Bot commented on CB-11694:
-------------------------------------

GitHub user matrosovN opened a pull request:

    https://github.com/apache/cordova-plugin-inappbrowser/pull/188

    CB-11694 Android: Set hadwareBackButton value according option in cor=
=E2=80=A6

    <!--
    Please make sure the checklist boxes are all checked before submitting =
the PR. The checklist
    is intended as a quick reference, for complete details please see our C=
ontributor Guidelines:
   =20
    http://cordova.apache.org/contribute/contribute_guidelines.html
   =20
    Thanks!
    -->
   =20
    ### Platforms affected
    Android
   =20
    ### What does this PR do?
    HadwareBackButton value persists across usages. By default hardwareBack=
 value is null. In this case we should set hadwareBackButton  to default va=
lue.
   =20
    ### What testing has been done on this change?
    Manual test
   =20
    ### Checklist
    - [x] [ICLA](http://www.apache.org/licenses/icla.txt) has been signed a=
nd submitted to secretary@apache.org.
    - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.h=
tml) in the JIRA database
    - [x] Commit message follows the format: "CB-3232: (android) Fix bug wi=
th resolving file paths", where CB-xxxx is the JIRA ID & "android" is the p=
latform affected.
    - [x] Added automated test coverage as appropriate for this change.
   =20


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/matrosovN/cordova-plugin-inappbrowser CB-=
11694

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-inappbrowser/pull/188.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #188
   =20
----
commit 71cf378af0a111e94fa4c94f2deb092ca65d3cf4
Author: Nikita Matrosov <nikita.matrosov@rp.ru>
Date:   2016-09-20T07:23:37Z

    CB-11694 Android: Set hadwareBackButton value according option in cordo=
va.InAppBrowser.open
   =20
    HadwareBackButton value persists across usages. By default hardwareBack=
 value is null. In this case we should set hadwareBackButton  to default va=
lue.

----


> hardwareback value persists across usages
> -----------------------------------------
>
>                 Key: CB-11694
>                 URL: https://issues.apache.org/jira/browse/CB-11694
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Plugin InAppBrowser
>    Affects Versions: 1.4.0
>            Reporter: Jacob Weber
>            Priority: Minor
>              Labels: Android, android, triaged
>
> 1. Open an InAppBrowser without passing hardwareback. It will use the def=
ault value ("yes"), so the hardware Back button will take you back in histo=
ry.
> 2. Open an InAppBrowser and pass hardwareback=3Dno. The hardware Back but=
ton will close the browser.
> 3. Open an InAppBrowser without passing hardwareback. It will now use the=
 previous value ("no"), so the hardware Back button will take you back in h=
istory. It should go back to the default value ("yes").


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org