cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-11909) Updating command in coho (prepare-release-branch) - grab the argv.version from package.json
Date Tue, 27 Sep 2016 23:35:20 GMT

    [ https://issues.apache.org/jira/browse/CB-11909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15527783#comment-15527783
] 

ASF GitHub Bot commented on CB-11909:
-------------------------------------

Github user audreyso commented on a diff in the pull request:

    https://github.com/apache/cordova-coho/pull/139#discussion_r80818236
  
    --- Diff: src/platform-release.js ---
    @@ -128,14 +127,32 @@ exports.prepareReleaseBranchCommand = function*() {
                    '\n' +
                    'Usage: $0 prepare-release-branch --version=3.6.0 -r platform')
         );
    +   
         var repos = flagutil.computeReposFromFlag(argv.r);
    -    var version = flagutil.validateVersionString(argv.version);
    -    var branchName = getVersionBranchName(version);
    +    var branchName = null;
    + 
     
         // First - perform precondition checks.
         yield repoupdate.updateRepos(repos, [], true);
     
         yield repoutil.forEachRepo(repos, function*(repo) {
    +       
    +        var version = null;
    +
    +        if (argv.version === undefined) {
    +            // Grabbing version from platformPackageJson
    --- End diff --
    
    All done!


> Updating command in coho (prepare-release-branch) - grab the argv.version from package.json
> -------------------------------------------------------------------------------------------
>
>                 Key: CB-11909
>                 URL: https://issues.apache.org/jira/browse/CB-11909
>             Project: Apache Cordova
>          Issue Type: Bug
>            Reporter: Audrey So
>            Assignee: Audrey So
>            Priority: Trivial
>
> If no version is passed in, grab the version from package.json



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message