cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-11815) hard-coded bridge name "cordova"
Date Wed, 07 Sep 2016 07:36:20 GMT

    [ https://issues.apache.org/jira/browse/CB-11815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15469874#comment-15469874
] 

ASF GitHub Bot commented on CB-11815:
-------------------------------------

GitHub user lucatorella opened a pull request:

    https://github.com/apache/cordova-plugin-wkwebview-engine/pull/18

    CB-11815: (iOS) Fix hard-coded bridge name "cordova"

    <!--
    Please make sure the checklist boxes are all checked before submitting the PR. The checklist
    is intended as a quick reference, for complete details please see our Contributor Guidelines:
    
    http://cordova.apache.org/contribute/contribute_guidelines.html
    
    Thanks!
    -->
    
    ### Platforms affected
    
    
    ### What does this PR do?
    
    
    ### What testing has been done on this change?
    
    
    ### Checklist
    - [ ] [ICLA](http://www.apache.org/licenses/icla.txt) has been signed and submitted to
secretary@apache.org.
    - [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA
database
    - [ ] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [ ] Added automated test coverage as appropriate for this change.
    
    ### Platforms affected
    iOS
    
    ### What does this PR do?
    Replaced hard coded string.
    
    ### What testing has been done on this change?
    No test necessary
    
    ### Checklist
    - [x] [ICLA](http://www.apache.org/licenses/icla.txt) has been signed and submitted to
secretary@apache.org.
    - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA
database
    - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [x] Added automated test coverage as appropriate for this change.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/lucatorella/cordova-plugin-wkwebview-engine patch-1

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-wkwebview-engine/pull/18.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #18
    
----
commit 7db0190f2e2689197fa30fb5f0d83eaad867a631
Author: Luca Torella <lucatorella@gmail.com>
Date:   2016-09-07T07:35:52Z

    CB-11815: (iOS) Fix hard-coded bridge name "cordova"
    
    ### Platforms affected
    iOS
    
    ### What does this PR do?
    Replaced hard coded string.
    
    ### What testing has been done on this change?
    No test necessary
    
    ### Checklist
    - [x] [ICLA](http://www.apache.org/licenses/icla.txt) has been signed and submitted to
secretary@apache.org.
    - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA
database
    - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [x] Added automated test coverage as appropriate for this change.

----


> hard-coded bridge name "cordova"
> --------------------------------
>
>                 Key: CB-11815
>                 URL: https://issues.apache.org/jira/browse/CB-11815
>             Project: Apache Cordova
>          Issue Type: Improvement
>      Security Level: Public(Anyone can view this level - this is the default.) 
>          Components: Plugin WKWebViewEngine
>            Reporter: Shazron Abdullah
>            Assignee: Shazron Abdullah
>              Labels: easyfix
>
> https://github.com/apache/cordova-plugin-wkwebview-engine/blob/a1da5d22c091ed1d30536ccb31f43a107d89ed4c/src/ios/CDVWKWebViewEngine.m#L101
> use CDV_BRIDGE_NAME



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message