cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-11811) CocoaPods error in cordova-lib tests
Date Fri, 09 Sep 2016 00:29:20 GMT

    [ https://issues.apache.org/jira/browse/CB-11811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15475452#comment-15475452
] 

ASF GitHub Bot commented on CB-11811:
-------------------------------------

Github user codecov-io commented on the issue:

    https://github.com/apache/cordova-lib/pull/489
  
    ## [Current coverage](https://codecov.io/gh/apache/cordova-lib/pull/489?src=pr) is 25.34%
(diff: 100%)
    > Merging [#489](https://codecov.io/gh/apache/cordova-lib/pull/489?src=pr) into [master](https://codecov.io/gh/apache/cordova-lib/branch/master?src=pr)
will decrease coverage by **55.03%**
    
    ```diff
    @@             master       #489   diff @@
    ==========================================
      Files            67          7     -60   
      Lines          5183        509   -4674   
      Methods         835         88    -747   
      Messages          0          0           
      Branches       1005        108    -897   
    ==========================================
    - Hits           4166        129   -4037   
    + Misses         1017        380    -637   
      Partials          0          0           
    ```
    
    > Powered by [Codecov](https://codecov.io?src=pr). Last update [f8b58c7...56c00eb](https://codecov.io/gh/apache/cordova-lib/compare/f8b58c782c71558516adbbd81929ee31ec3ded7f...56c00eb0f25483b9e7db0b9ff9ae63f6830939aa?src=pr)


> CocoaPods error in cordova-lib tests
> ------------------------------------
>
>                 Key: CB-11811
>                 URL: https://issues.apache.org/jira/browse/CB-11811
>             Project: Apache Cordova
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the default.) 
>          Components: CordovaLib, iOS
>            Reporter: Shazron Abdullah
>            Assignee: Shazron Abdullah
>
> https://github.com/apache/cordova-lib/blob/3b38b5382b9a52d1fe522514b61d3ebd6016796d/cordova-lib/spec-cordova/platform.spec.js#L380
> {code}
> Failures:
>   1) cocoapod plugin add and rm end-to-end installs and uninstalls plugin depending on
new pod and existing pod
>    Message:
>      Expected 'CocoaPods was not found. Please install version 1.0.1 or greater from
https://cocoapods.org/' to be undefined.
>    Stacktrace:
>      Error: Expected 'CocoaPods was not found. Please install version 1.0.1 or greater
from https://cocoapods.org/' to be undefined.
>     at /home/jenkins/jenkins-slave/workspace/cordova-nightly/cordova-lib/cordova-lib/spec-cordova/platform.spec.js:467:25
>     at _rejected (/home/jenkins/jenkins-slave/workspace/cordova-nightly/cordova-lib/cordova-lib/node_modules/q/q.js:797:24)
>     at /home/jenkins/jenkins-slave/workspace/cordova-nightly/cordova-lib/cordova-lib/node_modules/q/q.js:823:30
>     at Promise.when (/home/jenkins/jenkins-slave/workspace/cordova-nightly/cordova-lib/cordova-lib/node_modules/q/q.js:1035:31)
>     at Promise.promise.promiseDispatch (/home/jenkins/jenkins-slave/workspace/cordova-nightly/cordova-lib/cordova-lib/node_modules/q/q.js:741:41)
>     at /home/jenkins/jenkins-slave/workspace/cordova-nightly/cordova-lib/cordova-lib/node_modules/q/q.js:557:44
>     at flush (/home/jenkins/jenkins-slave/workspace/cordova-nightly/cordova-lib/cordova-lib/node_modules/q/q.js:108:17)
>     at process._tickCallback (node.js:415:13)
> {code}
> The test is now invalid, since to properly install a CocoaPod dependency in a project,
cocoapods cli needs to be installed. The implementation did not check for this before (thus
it didn't fail), but it does now.
> There is no way to test this without CocoaPods being installed, all we can really test
is if the error message is correct.
> To test e2e CocoaPods, we need to separate this test as an OS X only test, and run this
test on Travis CI only.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message