cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-11790) Check that Cocoapods is installed by checking `pod install` return code, show help text
Date Mon, 05 Sep 2016 06:31:20 GMT

    [ https://issues.apache.org/jira/browse/CB-11790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15464229#comment-15464229
] 

ASF GitHub Bot commented on CB-11790:
-------------------------------------

Github user codecov-io commented on the issue:

    https://github.com/apache/cordova-ios/pull/253
  
    ## [Current coverage](https://codecov.io/gh/apache/cordova-ios/pull/253?src=pr) is 56.90%
(diff: 64.38%)
    > Merging [#253](https://codecov.io/gh/apache/cordova-ios/pull/253?src=pr) into [master](https://codecov.io/gh/apache/cordova-ios/branch/master?src=pr)
will increase coverage by **0.95%**
    
    ```diff
    @@             master       #253   diff @@
    ==========================================
      Files            11         12     +1   
      Lines          1017       1086    +69   
      Methods         147        169    +22   
      Messages          0          0          
      Branches        171        174     +3   
    ==========================================
    + Hits            569        618    +49   
    - Misses          448        468    +20   
      Partials          0          0          
    ```
    
    > Powered by [Codecov](https://codecov.io?src=pr). Last update [aa28508...1673350](https://codecov.io/gh/apache/cordova-ios/compare/aa28508d1e31e3b8c210494b73a906372d31daa3...1673350afd24d919658c66c1b779fd7395558d87?src=pr)


>  Check that Cocoapods is installed by checking `pod install` return code, show help text
> ----------------------------------------------------------------------------------------
>
>                 Key: CB-11790
>                 URL: https://issues.apache.org/jira/browse/CB-11790
>             Project: Apache Cordova
>          Issue Type: Sub-task
>      Security Level: Public(Anyone can view this level - this is the default.) 
>          Components: iOS
>            Reporter: Shazron Abdullah
>            Assignee: Shazron Abdullah
>
> Line: https://github.com/apache/cordova-ios/blob/826db773df6b0297a9d0b2e7889b9a028a80fe5f/bin/templates/scripts/cordova/lib/podMod.js#L59
> If it is not installed, we must error out and warn the user what to do. Currently, it
just silently fails (pod install is called, but its error code is not checked). 
> We need to decide what to do with the user experience issue if pod install is first run
-- this triggers a Cocoapods repo clone, which at the time I write this is 475MB. The time
to download this repo is non-trivial, and the size of the repo increases linearly each day.
We should add a notice to the output that it might take a long time.
> Additionally, we could report the size of the Cocoapods repo by using the Github API
like this Chrome Extension: https://github.com/harshjv/github-repo-size



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message