cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-11776) Can't add two plugins with different edit-config targets
Date Mon, 19 Sep 2016 18:02:20 GMT

    [ https://issues.apache.org/jira/browse/CB-11776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15504169#comment-15504169
] 

ASF GitHub Bot commented on CB-11776:
-------------------------------------

GitHub user ktop opened a pull request:

    https://github.com/apache/cordova-lib/pull/491

    CB-11776 Fix can't add two plugins with different edit-config targets

    An error was thrown when adding two plugins with different edit-config targets. The conflict
checking code was missing a case, so it errors out and the second plugin cannot be added.

    
    I fixed the conflict checking and added a test case. 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ktop/cordova-lib ecerror

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-lib/pull/491.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #491
    
----
commit 7b1354ac0090a36133f7fb742fb2090673e200d5
Author: ktop <ktop500@gmail.com>
Date:   2016-09-19T17:53:51Z

    CB-11776 Fix can't add two plugins with different edit-config targets

----


> Can't add two plugins with different edit-config targets
> --------------------------------------------------------
>
>                 Key: CB-11776
>                 URL: https://issues.apache.org/jira/browse/CB-11776
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: CordovaCommon
>    Affects Versions: 1.4.0
>            Reporter: Karen Tran
>            Assignee: Karen Tran
>              Labels: edit-config, triaged
>             Fix For: Master
>
>
> When adding two plugins where both plugins are using edit-config, the second plugin will
have issues being added. The conflict checking for edit-config is missing a case where the
target cannot resolve to an existing target. Should check if the target exists before proceeding.




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message