cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Philipp Kursawe (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-11394) backbutton eventlistener should be able to let cordova execute the default native behaviour
Date Thu, 15 Sep 2016 00:26:21 GMT

    [ https://issues.apache.org/jira/browse/CB-11394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15491876#comment-15491876
] 

Philipp Kursawe commented on CB-11394:
--------------------------------------

about the backbutton, yes. That was a typo, I changed it in the OP.
But I would guess the others button events are also handled wrong.

> backbutton eventlistener should be able to let cordova execute the default native behaviour
> -------------------------------------------------------------------------------------------
>
>                 Key: CB-11394
>                 URL: https://issues.apache.org/jira/browse/CB-11394
>             Project: Apache Cordova
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the default.) 
>          Components: Android
>            Reporter: Philipp Kursawe
>
> When we override the "backbutton" with a custom handler, cordova completly skips handling
of the native behaviour (as written in the docs).
> It does this even though the events `defaultPrevented` property is set to `false`. A
proper implementation of event handling would look into this property  and act accordingly.
> Not sure how this could be introduced now without breaking old code.
> Probably old code never returns a value from the event handler. So a patch could check
if the return value is `===true` then it should perform the default native behaviour of that
button.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message