Return-Path: <issues-return-70290-archive-asf-public=cust-asf.ponee.io@cordova.apache.org>
X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io
Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io
Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183])
	by cust-asf2.ponee.io (Postfix) with ESMTP id 414FE200B67
	for <archive-asf-public-internal@cust-asf2.ponee.io>; Mon,  1 Aug 2016 12:39:22 +0200 (CEST)
Received: by cust-asf.ponee.io (Postfix)
	id 3C946160A5D; Mon,  1 Aug 2016 10:39:22 +0000 (UTC)
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by cust-asf.ponee.io (Postfix) with SMTP id 8A2E4160A65
	for <archive-asf-public@cust-asf.ponee.io>; Mon,  1 Aug 2016 12:39:21 +0200 (CEST)
Received: (qmail 135 invoked by uid 500); 1 Aug 2016 10:39:20 -0000
Mailing-List: contact issues-help@cordova.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:issues-help@cordova.apache.org>
List-Unsubscribe: <mailto:issues-unsubscribe@cordova.apache.org>
List-Post: <mailto:issues@cordova.apache.org>
List-Id: <issues.cordova.apache.org>
Delivered-To: mailing list issues@cordova.apache.org
Received: (qmail 99937 invoked by uid 99); 1 Aug 2016 10:39:20 -0000
Received: from arcas.apache.org (HELO arcas) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 01 Aug 2016 10:39:20 +0000
Received: from arcas.apache.org (localhost [127.0.0.1])
	by arcas (Postfix) with ESMTP id 7D95E2C027F
	for <issues@cordova.apache.org>; Mon,  1 Aug 2016 10:39:20 +0000 (UTC)
Date: Mon, 1 Aug 2016 10:39:20 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: issues@cordova.apache.org
Message-ID: <JIRA.12988684.1468320359000.184936.1470047960510@Atlassian.JIRA>
In-Reply-To: <JIRA.12988684.1468320359000@Atlassian.JIRA>
References: <JIRA.12988684.1468320359000@Atlassian.JIRA> <JIRA.12988684.1468320359314@arcas>
Subject: [jira] [Commented] (CB-11558) Make windows plugin rm remove
 ProjectReference items
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394
archived-at: Mon, 01 Aug 2016 10:39:22 -0000


    [ https://issues.apache.org/jira/browse/CB-11558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15401813#comment-15401813 ] 

ASF GitHub Bot commented on CB-11558:
-------------------------------------

Github user vladimir-kotikov commented on a diff in the pull request:

    https://github.com/apache/cordova-windows/pull/185#discussion_r72957333
  
    --- Diff: template/cordova/lib/PluginHandler.js ---
    @@ -105,7 +105,7 @@ var handlers = {
                 var type = obj.type;
     
                 if(type === 'projectReference') {
    -                project.removeProjectReference(path.join(plugin.dir, src), getTargetConditions(obj));
    +                project.removeProjectReference(path.join('..', '..', 'plugins', plugin.id, src), getTargetConditions(obj));
    --- End diff --
    
    Another thing is that when we add project reference, we use [`targetDir`](https://github.com/apache/cordova-windows/pull/185/files#diff-7bcd02ec7f03ffbb25512bd1f4a0d388L91) attribute when defined. Shouldn't we add it to path here as well?


> Make windows plugin rm remove ProjectReference items
> ----------------------------------------------------
>
>                 Key: CB-11558
>                 URL: https://issues.apache.org/jira/browse/CB-11558
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Windows
>            Reporter: Sergey Shakhnazarov
>            Assignee: Sergey Shakhnazarov
>              Labels: triaged, windows
>
> {{cordova plugin add phonegap-plugin-barcodescanner}}
> CordovaApp.Windows.jsproj ->
> {noformat}
>     <ItemGroup>
>         <ProjectReference Include="..\..\plugins\phonegap-plugin-barcodescanner\src\windows\lib\WinRTBarcodeReader.csproj" />
>     </ItemGroup>
> {noformat}
> {{cordova plugin rm phonegap-plugin-barcodescanner}}
> {{ItemGroup}} not being removed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org