Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id AA9BB200B5A for ; Thu, 4 Aug 2016 16:24:22 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id A8FB5160AAE; Thu, 4 Aug 2016 14:24:22 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id F1542160AAB for ; Thu, 4 Aug 2016 16:24:21 +0200 (CEST) Received: (qmail 7520 invoked by uid 500); 4 Aug 2016 14:24:21 -0000 Mailing-List: contact issues-help@cordova.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@cordova.apache.org Received: (qmail 7174 invoked by uid 99); 4 Aug 2016 14:24:21 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 04 Aug 2016 14:24:21 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 00D492C0D60 for ; Thu, 4 Aug 2016 14:24:21 +0000 (UTC) Date: Thu, 4 Aug 2016 14:24:21 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@cordova.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CB-11300) Undetected 4g connection in cordova network information plugin MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Thu, 04 Aug 2016 14:24:22 -0000 [ https://issues.apache.org/jira/browse/CB-11300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15407844#comment-15407844 ] ASF GitHub Bot commented on CB-11300: ------------------------------------- Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-network-information/pull/46 Cordova CI Build has completed successfully. **Commit** - [Link](https://github.com/apache/cordova-plugin-network-information/pull/46/commits/d29f28f6c48e3d8458419d71d69c3a7f89c60354) **Dashboard** - [Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-network-information-pr/14/) | Builder Name | Console Output | Test Report | Device Logs | | :---: | :---: | :---: | :---: | | [Windows 8.1 Store]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-network-information-pr/14//PLATFORM=windows-8.1-store/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-network-information-pr/14//PLATFORM=windows-8.1-store/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-network-information-pr/14//PLATFORM=windows-8.1-store/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-network-information-pr/14//PLATFORM=windows-8.1-store/artifact/) | | [Windows 10 Store]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-network-information-pr/14//PLATFORM=windows-10-store/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-network-information-pr/14//PLATFORM=windows-10-store/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-network-information-pr/14//PLATFORM=windows-10-store/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-network-information-pr/14//PLATFORM=windows-10-store/artifact/) | | [Windows 8.1 Phone]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-network-information-pr/14//PLATFORM=windows-8.1-phone/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-network-information-pr/14//PLATFORM=windows-8.1-phone/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-network-information-pr/14//PLATFORM=windows-8.1-phone/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-network-information-pr/14//PLATFORM=windows-8.1-phone/artifact/) | | [iOS]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-network-information-pr/14//PLATFORM=ios/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-network-information-pr/14//PLATFORM=ios/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-network-information-pr/14//PLATFORM=ios/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-network-information-pr/14//PLATFORM=ios/artifact/) | | [Android]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-network-information-pr/14//PLATFORM=android/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-network-information-pr/14//PLATFORM=android/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-network-information-pr/14//PLATFORM=android/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-network-information-pr/14//PLATFORM=android/artifact/) | > Undetected 4g connection in cordova network information plugin > -------------------------------------------------------------- > > Key: CB-11300 > URL: https://issues.apache.org/jira/browse/CB-11300 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin Network Information > Environment: Android > Reporter: Santi Calvo > Assignee: Alexander Sorokin > Priority: Minor > Labels: android, easyfix, network-information, network.connection, triaged > Attachments: Captura de pantalla 2016-05-20 a las 9.29.14 (2).png > > Original Estimate: 24h > Remaining Estimate: 24h > > My device returns "4g" as subtypename when checking the connection. Since this string is not found the plugin returns "unknow" connection. > The Java plugin, NeworkManager.java line 246, does the bellow check where the string "4g" doesn't match any of the constants: > else if (type.equals(MOBILE) || type.equals(CELLULAR)) { > type = info.getSubtypeName().toLowerCase(Locale.US); > if (type.equals(GSM) || > type.equals(GPRS) || > type.equals(EDGE)) { > return TYPE_2G; > } > else if (type.startsWith(CDMA) || > type.equals(UMTS) || > type.equals(ONEXRTT) || > type.equals(EHRPD) || > type.equals(HSUPA) || > type.equals(HSDPA) || > type.equals(HSPA)) { > return TYPE_3G; > } > else if (type.equals(LTE) || > type.equals(UMB) || > type.equals("4g") || > type.equals(HSPA_PLUS)) { > return TYPE_4G; > } > } -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org For additional commands, e-mail: issues-help@cordova.apache.org