cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Shazron Abdullah (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (CB-11790) Check that Cocoapods is installed before by checking `pod install` return code
Date Wed, 31 Aug 2016 00:47:20 GMT

     [ https://issues.apache.org/jira/browse/CB-11790?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Shazron Abdullah updated CB-11790:
----------------------------------
    Description: 
Line: https://github.com/apache/cordova-ios/blob/826db773df6b0297a9d0b2e7889b9a028a80fe5f/bin/templates/scripts/cordova/lib/podMod.js#L59

If it is not installed, we must error out and warn the user what to do. Currently, it just
silently fails (pod install is called, but its error code is not checked). 

We need to decide what to do with the user experience issue if pod install is first run --
this triggers a Cocoapods repo clone, which at the time I write this is 475MB. The time to
download this repo is non-trivial, and the size of the repo increases linearly each day. We
should add a notice to the output that it might take a long time.

  was:
Line: https://github.com/apache/cordova-ios/blob/826db773df6b0297a9d0b2e7889b9a028a80fe5f/bin/templates/scripts/cordova/lib/podMod.js#L59

Right now, it just fails silently.


>  Check that Cocoapods is installed before by checking `pod install` return code
> -------------------------------------------------------------------------------
>
>                 Key: CB-11790
>                 URL: https://issues.apache.org/jira/browse/CB-11790
>             Project: Apache Cordova
>          Issue Type: Sub-task
>      Security Level: Public(Anyone can view this level - this is the default.) 
>          Components: iOS
>            Reporter: Shazron Abdullah
>
> Line: https://github.com/apache/cordova-ios/blob/826db773df6b0297a9d0b2e7889b9a028a80fe5f/bin/templates/scripts/cordova/lib/podMod.js#L59
> If it is not installed, we must error out and warn the user what to do. Currently, it
just silently fails (pod install is called, but its error code is not checked). 
> We need to decide what to do with the user experience issue if pod install is first run
-- this triggers a Cocoapods repo clone, which at the time I write this is 475MB. The time
to download this repo is non-trivial, and the size of the repo increases linearly each day.
We should add a notice to the output that it might take a long time.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message