cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-11783) Intent scheme should be handled by Android OS
Date Mon, 29 Aug 2016 15:38:20 GMT

    [ https://issues.apache.org/jira/browse/CB-11783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15446206#comment-15446206
] 

ASF GitHub Bot commented on CB-11783:
-------------------------------------

GitHub user GavinPacini opened a pull request:

    https://github.com/apache/cordova-plugin-inappbrowser/pull/183

    CB-11783: (android) Add intent scheme to be handled by OS

    ### Platforms affected
    Android
    
    ### What does this PR do?
    The intent scheme `intent://` is [recommended by Google ](https://developer.chrome.com/multidevice/android/intents)
for launching apps. Cordova should forward this to the OS to handle appropriately.
    
    ### What testing has been done on this change?
    Intent is forwarded to the OS and provides the application handler dialog for the user
to select an app.
    
    ### Checklist
    - [X] [ICLA](http://www.apache.org/licenses/icla.txt) has been signed and submitted to
secretary@apache.org.
    - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA
database
    - [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [X] Added automated test coverage as appropriate for this change.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/GavinPacini/cordova-plugin-inappbrowser patch-1

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-inappbrowser/pull/183.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #183
    
----
commit df084ff869cc33213171f4ffaef01c54838a472a
Author: Gavin Pacini <gavinpacini@users.noreply.github.com>
Date:   2016-08-29T15:20:12Z

    Add intent scheme to be handled by OS
    
    The intent scheme `intent://` is [recommended by Google ](https://developer.chrome.com/multidevice/android/intents)
for launching apps. Cordova should forward this to the OS to handle appropriately.

----


> Intent scheme should be handled by Android OS
> ---------------------------------------------
>
>                 Key: CB-11783
>                 URL: https://issues.apache.org/jira/browse/CB-11783
>             Project: Apache Cordova
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the default.) 
>          Components: Plugin InAppBrowser
>    Affects Versions: Master
>         Environment: Android 6.0 on OnePlus 3 with Oxygen OS 3.2.4
>            Reporter: Gavin Pacini
>              Labels: android
>
> The intent scheme (intent://) is recommended by Google (https://developer.chrome.com/multidevice/android/intents)
for launching apps. Cordova should forward this to the OS to handle appropriately.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message