cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-11757) media.stop() should call error callback when called in MEDIA_STARTING state
Date Sun, 28 Aug 2016 15:07:20 GMT

    [ https://issues.apache.org/jira/browse/CB-11757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15443581#comment-15443581
] 

ASF GitHub Bot commented on CB-11757:
-------------------------------------

Github user cordova-qa commented on the issue:

    https://github.com/apache/cordova-plugin-media/pull/113
  
    Cordova CI Build has completed successfully.
    
    **Commit**     - [Link](https://github.com/apache/cordova-plugin-media/pull/113/commits/13bcd820d6baa4877b5821e1ed384f70d73794d9)
    **Dashboard** - [Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/76/)
    
    | Builder Name  | Console Output | Test Report | Device Logs  |
    |     :---:     |     :---:      |   :---:     |     :---:    |
    | [Windows 8.1 Store]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/76//PLATFORM=windows-8.1-store/)
| [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/76//PLATFORM=windows-8.1-store/console)
| [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/76//PLATFORM=windows-8.1-store/testReport/)
| [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/76//PLATFORM=windows-8.1-store/artifact/)
|
    | [Windows 10  Store]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/76//PLATFORM=windows-10-store/)
| [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/76//PLATFORM=windows-10-store/console)
| [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/76//PLATFORM=windows-10-store/testReport/)
| [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/76//PLATFORM=windows-10-store/artifact/)
|
    | [Windows 8.1 Phone]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/76//PLATFORM=windows-8.1-phone/)
| [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/76//PLATFORM=windows-8.1-phone/console)
| [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/76//PLATFORM=windows-8.1-phone/testReport/)
| [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/76//PLATFORM=windows-8.1-phone/artifact/)
|
    | [iOS]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/76//PLATFORM=ios/)
| [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/76//PLATFORM=ios/console)
| [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/76//PLATFORM=ios/testReport/)
| [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/76//PLATFORM=ios/artifact/)
|
    | [Android]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/76//PLATFORM=android/)
| [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/76//PLATFORM=android/console)
| [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/76//PLATFORM=android/testReport/)
| [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/76//PLATFORM=android/artifact/)
|
     



> media.stop() should call error callback when called in MEDIA_STARTING state
> ---------------------------------------------------------------------------
>
>                 Key: CB-11757
>                 URL: https://issues.apache.org/jira/browse/CB-11757
>             Project: Apache Cordova
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the default.) 
>          Components: iOS, Plugin Media
>    Affects Versions: Master
>            Reporter: Alexander Sorokin
>            Assignee: Alexander Sorokin
>              Labels: triaged
>
> On iOS, when calling media.stop() when media is in state MEDIA_STARTING (for example,
the player is caching media file), we don't get any callback. And then, when the caching is
completed, the media actually starts playing.
> The proposed fix is that when media.stop() is called in an invalid state, the plugin
should send an error callback with the code MEDIA_ERR_NONE_ACTIVE
> Another approach would be to stop the playback as soon as the player finishes caching.
One possible advantage of this over the proposed fix would be that MEDIA_ERR_NONE_ACTIVE is
not in w3c spec:
> https://dev.w3.org/html5/spec-author-view/video.html#error-codes



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message